[ https://issues.apache.org/jira/browse/PROTON-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129037#comment-15129037 ]
Andrew Stitcher commented on PROTON-1116: ----------------------------------------- I approve the fix for 0.12 > Potential infinite recursion detected by VC++14 compiler > -------------------------------------------------------- > > Key: PROTON-1116 > URL: https://issues.apache.org/jira/browse/PROTON-1116 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding > Affects Versions: 0.12.0 > Environment: Visual Studio 2015 Update 1, Visual Studio 2010 > Reporter: Andrew Stitcher > Assignee: Alan Conway > Priority: Blocker > > I get the following warning when running the Visual Studio 2015 compiler on > the C++ binding code > {noformat} > 29>c:\users\andrew\documents\github\qpid-proton\proton-c\bindings\cpp\include\proton\value.hpp(49): > warning C4717: > 'proton::value::value<std::pair<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,proton::value> >': recursive on all control paths, function will cause > runtime stack overflow > {noformat} > My guess is that we never actually try to run this code in the tests or e > would indeed by seeing a failure, however I think we must eliminate this as a > bug before releasing 0.12. > Either remove the code so removing the warning (as the code seems like it > can't have been called in testing) or fix the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)