[ https://issues.apache.org/jira/browse/PROTON-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150849#comment-15150849 ]
Andrew Stitcher commented on PROTON-515: ---------------------------------------- These changes look good. Small details: Do you use cmake to build on OpenVMS? You don't seem to have added any way to select an OpenVMS build. If you use something else would you consider adding a small documentation file detailing how to build proton using OpenVMS so that someone else could benefit from your work? Is socklen_t not defined at all on OpenVMS? It is a pretty necessary part of the sockets API. I would expect it to be in <sys/socket.h>. So rather than the #ifdef try just: #include <sys/socket.h> which I'd prefer, if that really doesn't work then I guess the ifdef is acceptable. > Port to OpenVMS > --------------- > > Key: PROTON-515 > URL: https://issues.apache.org/jira/browse/PROTON-515 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c > Affects Versions: 0.11.1 > Environment: OpenVMS > Reporter: Tomas Soltys > Assignee: Andrew Stitcher > Labels: OpenVMS, patch > Attachments: > 0001-PROTON-515-Change-pn_handle_t-to-be-void-to-get-arou.patch, > CMakeLists.txt.patch, io.c.patch, pipe.c.patch > > > There is a need for proton-c port to OpenVMS platform. > To make proton-c functional on OpenVMS few changes in the source code are > required. > Here is list of files I have identified which require some attention: > proton-c/src/platform_fmt.h > proton-c/src/posix/driver.c > proton-c/src/object/object.c > proton-c/src/codec/codec.c -- This message was sent by Atlassian JIRA (v6.3.4#6332)