Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/72#discussion_r58066861
--- Diff: proton-c/bindings/javascript/CMakeLists.txt ---
@@ -192,6 +192,7 @@ target_link_libraries(qpid-proton-bitcode)
# Compile the send-async.c and recv-async.c examples into JavaScript
+include_directories(${PN_PATH}/../examples/c/include)
--- End diff --
It might be better to avoid relative paths and use
${Proton_SOURCE_DIR}/examples/c/include
My spidey sense tells me that this would be more robust in the face of
changes, but I can't really substantiate that.
This would also apply to the relative paths in the lines below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
