I'm sorry that I took a long time to look at this. It seems reasonable to me, at a glance. John, do you want to shepherd this in? Otherwise I'll take another look and try to get it in myself after I return from vacation Aug. 18.
On Mon, Jul 27, 2015 at 11:13:52PM -0500, Alan Mead wrote: > Attached is a patch to 0.8.5 quick-cluster.c to support the > /PRINT=CLUSTER subcommand that identifies the cluster membership of each > case in the analysis. I also included test syntax, data, and output. > > John has suggested some stylistic changes that are included in this > patch, but three last three suggestions are not in this patch: > > > I think this patch could be checked in if we also do the following: > > > > > > 1. Add the necessary changes to doc/statistics.texi documenting the > > /PRINT subcommand. > > > > 2. Add a test to tests/language/stats/quick-cluster.at which exercises > > the /PRINT subcommand. > > > > 3. We should omit the syntax parsing code for the /SAVE command, because > > it doesn't do anything yet. > > In addition, I've been looking over the regression.c code to see how it > implements /SAVE but I'm not sure I can replicate it in the cluster code. _______________________________________________ pspp-dev mailing list [email protected] https://lists.gnu.org/mailman/listinfo/pspp-dev
