On Thu, Oct 08, 2015 at 09:21:39PM -0700, Ben Pfaff wrote:
>
> This yields a new warning:
>
> ../src/data/file-handle-def.c: In function 'fh_create_file':
> ../src/data/file-handle-def.c:230:68: error: unused parameter
> 'file_name_encoding' [-Werror=unused-parameter]
>
> I'd prefer not to add commented-out code, as here:
>
> {
> char *handle_name;
> struct file_handle *handle;
>
> + // printf ("%s:%d Creating file handle for file %s with encoding %s\n",
> __FILE__, __LINE__, file_name, file_name_encoding);
>
> Otherwise this makes sense, thanks!
Actually, this causes build failures in the Perl module:
PSPP.xs: In function ‘XS_PSPP__Sysfile_pxs_create_sysfile’:
PSPP.xs:641:31: warning: passing argument 3 of ‘fh_create_file’ from
incompatible pointer type
fh_create_file (NULL, name, fh_default_properties () );
^
In file included from PSPP.xs:45:0:
/home/blp/pspp/master/src/data/file-handle-def.h:77:21: note: expected ‘const
char *’ but argument is of type ‘const struct fh_properties *’
struct file_handle *fh_create_file (const char *handle_name,
^
PSPP.xs:641:3: error: too few arguments to function ‘fh_create_file’
fh_create_file (NULL, name, fh_default_properties () );
^
In file included from PSPP.xs:45:0:
/home/blp/pspp/master/src/data/file-handle-def.h:77:21: note: declared here
struct file_handle *fh_create_file (const char *handle_name,
^
PSPP.xs: In function ‘XS_PSPP__Reader_pxs_open_sysfile’:
PSPP.xs:755:32: warning: passing argument 3 of ‘fh_create_file’ from
incompatible pointer type
fh_create_file (NULL, name, fh_default_properties () );
^
In file included from PSPP.xs:45:0:
/home/blp/pspp/master/src/data/file-handle-def.h:77:21: note: expected ‘const
char *’ but argument is of type ‘const struct fh_properties *’
struct file_handle *fh_create_file (const char *handle_name,
^
PSPP.xs:755:4: error: too few arguments to function ‘fh_create_file’
fh_create_file (NULL, name, fh_default_properties () );
^
In file included from PSPP.xs:45:0:
/home/blp/pspp/master/src/data/file-handle-def.h:77:21: note: declared here
struct file_handle *fh_create_file (const char *handle_name,
^
_______________________________________________
pspp-dev mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/pspp-dev
