On Sat, Feb 27, 2016 at 03:37:26PM -0800, Ben Pfaff wrote:
I think that removing this call is likely to cause problems. I think
it's likely to prevent columns from resizing themselves as columns are
added and deleted.
However, there's a lot of redundancy in calling
_pspp_sheet_view_column_cell_set_dirty() on all the columns. The
following code in it only needs to be done once, even if there are N
columns. If one were to factor that out or otherwise avoid running it N
times, it would probably improve performance a great deal.
if (tree_column->tree_view &&
gtk_widget_get_realized (tree_column->tree_view))
{
_pspp_sheet_view_install_mark_rows_col_dirty (PSPP_SHEET_VIEW
(tree_column->tree_view));
gtk_widget_queue_resize (tree_column->tree_view);
}I posted a patch based on this suggestion to the tracker. J' -- Avoid eavesdropping. Send strong encryted email. PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key.
signature.asc
Description: Digital signature
_______________________________________________ pspp-dev mailing list [email protected] https://lists.gnu.org/mailman/listinfo/pspp-dev
