Wolfram Sang wrote:
> Provide a dummy, no-op version of strip as a lot of makefiles (and install -s)
> execute just 'strip' and this leaks in the host version. This approach should
> be OK as we do stripping at a later stage anyway.
> 
> Signed-off-by: Wolfram Sang <w.s...@pengutronix.de>
> ---
> 
> I threw away the patches for NMAP and still could build it \o/
> 
> @Marc: This package needs to be processed before packages for the target are
> built. Where is it best to add the dependency?
> 
> @all: Do you see any side-effects?
> 
>  rules/cross-dummy-strip.in   |    5 +++++
>  rules/cross-dummy-strip.make |   33 +++++++++++++++++++++++++++++++++
>  scripts/dummy-strip.sh       |    8 ++++++++
>  3 files changed, 46 insertions(+), 0 deletions(-)
>  create mode 100644 rules/cross-dummy-strip.in
>  create mode 100644 rules/cross-dummy-strip.make
>  create mode 100644 scripts/dummy-strip.sh
> 
> diff --git a/rules/cross-dummy-strip.in b/rules/cross-dummy-strip.in
> new file mode 100644
> index 0000000..9cd921a
> --- /dev/null
> +++ b/rules/cross-dummy-strip.in
> @@ -0,0 +1,5 @@
> +## SECTION=crosstools
> +
> +config CROSS_DUMMY_STRIP
> +     bool
> +     default y
> diff --git a/rules/cross-dummy-strip.make b/rules/cross-dummy-strip.make
> new file mode 100644
> index 0000000..ca8feab
> --- /dev/null
> +++ b/rules/cross-dummy-strip.make
> @@ -0,0 +1,33 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2009 by Wolfram Sang <w.s...@pengutronix.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +CROSS_PACKAGES-$(PTXCONF_CROSS_DUMMY_STRIP) += cross-dummy-strip
> +
> +$(STATEDIR)/cross-dummy-strip.extract:
> +     @$(call targetinfo)
> +     @$(call touch, $@)
                     ^^^^
please remove

> +
> +$(STATEDIR)/cross-dummy-strip.prepare:
> +     @$(call targetinfo)
> +     @$(call touch, $@)

dito

> +
> +$(STATEDIR)/cross-dummy-strip.compile:
> +     @$(call targetinfo)
> +     @$(call touch, $@)

dito

> +
> +$(STATEDIR)/cross-dummy-strip.install:
> +     @$(call targetinfo)
> +     install -D -m 755 $(PTXDIST_TOPDIR)/scripts/dummy-strip.sh 
> $(PTXCONF_SYSROOT_CROSS)/bin/strip
> +     @$(call touch, $@)

dito

> +# vim: syntax=make
> diff --git a/scripts/dummy-strip.sh b/scripts/dummy-strip.sh
> new file mode 100644
> index 0000000..3546592

the rest ist just nitpicking

> --- /dev/null
> +++ b/scripts/dummy-strip.sh
> @@ -0,0 +1,8 @@
> +#! /bin/sh
> +#
> +# This scripts gets installed into the cross-environment as a 'dummy'-strip
> +# program. As programs like 'install -s' just call 'strip', this prevents
> +# leaking in of the host-version of strip. Also, it does intentionally
> +# nothing as we want to strip at a later stage.
IMHO it looks better with an "#" here
> +echo "ptxdist: Discarding strip command '$0 $*'"
use $@ here (however it makes no big difference here:)

cheers, Marc

-- 
Pengutronix e.K.                         | Marc Kleine-Budde           |
Linux Solutions for Science and Industry | Phone: +49-231-2826-924     |
Vertretung West/Dortmund                 | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686         | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature

--
ptxdist mailing list
ptxdist@pengutronix.de

Reply via email to