Hi All,
I have some comments on this patch below:
2010/1/13 Carsten Schlote <carsten.schl...@gmx.net>:
> [udev] Updated to version 150 and updated targetinstall
>
> Updated to 150 as proposed on ptxdist mailinglist. Compiles
> and works (tested with upstart initmethod).
>
> Added new config options for all files installed in package
> dir.
>
> Added install_copy lines for all files found in package dir
> and as well some more obscure ones not installed by default.
>
> Crosscompile Patches:
> - commented out checks for pci.ids and provide link to file directly.
>
> Signed-off-by: Carsten Schlote <c.schl...@konzeptpark.de>
>
> diff --git a/patches/udev-150/autogen.sh b/patches/udev-150/autogen.sh
> new file mode 120000
> index 0000000..9f8a4cb
> --- /dev/null
> +++ b/patches/udev-150/autogen.sh
> @@ -0,0 +1 @@
> +../autogen.sh
> \ No newline at end of file
> diff --git a/patches/udev-150/fix-crosscompile.patch
> b/patches/udev-150/fix-crosscompile.patch
> new file mode 100644
> index 0000000..5a811eb
> --- /dev/null
> +++ b/patches/udev-150/fix-crosscompile.patch
> @@ -0,0 +1,29 @@
> +From: Carsten Schlote <c.schl...@konzeptpark.de>
> +Subject: Remove checks for pci.ids to allow cross-compilation.
> +
> +These checks for pci.ids seem to fail. So commented out and
> +path to pci.ids is provided with by commandline option on
> +configure.
> +
> +Signed-off-by: Carsten Schlote <c.schl...@konzeptpark.de>
> +---
> + configure.ac | 6 +++---
> + 1 file changed, 3 insertions(+), 3 deletions(-)
> +
> +Index: udev-146/configure.ac
> +===================================================================
> +--- udev-146.orig/configure.ac 2009-08-10 03:37:42.000000000 +0200
> ++++ udev-146/configure.ac 2009-12-09 10:11:53.000000000 +0100
> +@@ -69,9 +69,9 @@
> + PKG_CHECK_MODULES(USBUTILS, usbutils >= 0.82)
> + AC_SUBST([USB_DATABASE], [$($PKG_CONFIG --variable=usbids usbutils)])
> +
> +- AC_CHECK_FILES([/usr/share/pci.ids], [pciids=/usr/share/pci.ids])
> +- AC_CHECK_FILES([/usr/share/hwdata/pci.ids],
> [pciids=/usr/share/hwdata/pci.ids])
> +- AC_CHECK_FILES([/usr/share/misc/pci.ids],
> [pciids=/usr/share/misc/pci.ids])
> ++# AC_CHECK_FILES([/usr/share/pci.ids], [pciids=/usr/share/pci.ids])
> ++# AC_CHECK_FILES([/usr/share/hwdata/pci.ids],
> [pciids=/usr/share/hwdata/pci.ids])
> ++# AC_CHECK_FILES([/usr/share/misc/pci.ids],
> [pciids=/usr/share/misc/pci.ids])
> + AC_ARG_WITH(pci-ids-path,
> + AS_HELP_STRING([--pci-ids-path=DIR], [Path to pci.ids file]),
> + [PCI_DATABASE=${withval}],
> diff --git a/patches/udev-150/series b/patches/udev-150/series
> new file mode 100644
> index 0000000..1752ae8
> --- /dev/null
> +++ b/patches/udev-150/series
> @@ -0,0 +1 @@
> +fix-crosscompile.patch
> diff --git a/rules/udev.in b/rules/udev.in
> index 58db642..2adb224 100644
> --- a/rules/udev.in
> +++ b/rules/udev.in
> @@ -2,7 +2,12 @@
> menuconfig UDEV
> tristate
> prompt "udev "
> + select HOST_GPERF
> select ROOTFS_DEV
> + select ACL
> + select USBUTILS
> + select LIBUSB_COMPAT
> + select PCIUTILS
Why are these dependencies fixed?
Does not sound like a good idea to force PCIUTILS either when running
udev on ARM that does not have PCI support...
This patch wrongly assumes that every board using udev also has PCI
and USB support... So, why USBUTILS, and LIBUSB_COMPAT?
Kind regards,
Remy
--
ptxdist mailing list
ptxdist@pengutronix.de
