Hi,
2010/6/5 Michael Olbrich <[email protected]>: > On Fri, Jun 04, 2010 at 08:15:56PM +0200, Remy Bohmer wrote: >> Hi Michael, >> >> 2010/6/4 Michael Olbrich <[email protected]>: >> > On Mon, May 31, 2010 at 09:25:36PM +0200, Remy Bohmer wrote: >> >> 2010/5/31 Michael Olbrich <[email protected]>: >> >> > On Sat, May 29, 2010 at 11:08:31PM +0200, Remy Bohmer wrote: >> >> >> If no toolchain info is specified, skip check completely >> >> >> >> >> >> Ptxdist does a toolchain check, but if all fields are empty we >> >> >> assume it is an external (not an OSELAS) toolchain. >> >> > >> >> > This is for a non-oselas toolchain in your PATH and no >> >> > "selected_toolchain" >> >> > link in your BSP, right? >> >> >> >> Indeed, this is used for toolchains build with either crosstool-ng, or >> >> toolchains we got from CodeSourcery. >> >> These toolchains are in the PATH, but the 'selected_toolchain' link >> >> has no effect. >> >> If that link is there (or not there) and this patch is _not_ enabled, >> >> then this message appears: >> >> ------------------------------------------------------------------------------ >> >> info: insufficient information in your platformconfig file >> >> please use 'ptxdist toolchain </path/to/toolchain>' to select >> >> your toolchain >> >> ------------------------------------------------------------------------------ >> >> Notice that the toolchain link is there and valid, only the error >> >> message is bogus. >> >> If we fill the fields PTXCONF_CROSSCHAIN_VENDOR and >> >> PTXCONF_CROSSCHAIN_CHECK with valid >> >> values for these toolchains it even gives a more bogus error message: >> >> ------------------------------------------------------------------------------ >> >> error: sorry, no toolchain found, matching >> >> /opt/CodeSourcery/arm-none-linux-gnueabi/gcc-4.3.3-glibc-2.8-*/bin >> >> please use 'ptxdist toolchain </path/to/toolchain>' to select >> >> your toolchain >> >> ------------------------------------------------------------------------------ >> >> It searches for a toolchain in /opt in some magic path. Notice that >> >> the selected_toolchain points to a location in /home/<user>. >> >> So, it seems to skip the toolchain pointed in the link as well. >> >> >> >> So, anyway. The check should either be able to work with non OSELAS >> >> toolchains as well, or it needs to be able to disable the check. >> > >> > This is very strange. These messages come from do_select_toolchain_guess >> > (in bin/ptxdist). do_select_toolchain_guess is only called when calling >> > "ptxdist toolchain" or when selected_toolchain does not exist (the errors >> > are supressed in this case). >> > >> > Is this with current git master? What exactly are you doing when you get >> > these messages? >> >> Well, the problem only occurs if we call this >> ptxdist platform /some/path/to/my/platform_config >> >> It does not occur on a sole 'ptxdist go' . >> >> And it occurs with a unmodified current git master. > > Now I see it. Hmmm, is it possible build a BSP without a selected_toolchain > link (or --toolchain=...)? Yes, that is possible, as long as the required toolchain is in the PATH. > If not, I think there should be an aditional warning if it's missing. > Otherwise this patch is ok. > Marc, what do you think? Kind regards, Remy -- ptxdist mailing list [email protected]
