Hi, On Wed, Apr 13, 2011 at 08:08:12AM +0200, Alexander Dahl wrote: > Am 12.04.2011 23:45, schrieb Michael Olbrich: > > this patch is broken. Your email probram added some line-breaks. > > I assumed this would be the case. Was my first patch and I read > somewhere: just import the output of `git format-patch` to your MUA and > send it. Thunderbird seems to break it. I'll try another way next time.
There should be an option to not break lines. But I don't use Thunderbird... > >> --- > >> rules/file.in | 15 +++++++ > >> rules/file.make | 102 > >> ++++++++++++++++++++++++++++++++++++++++++++++++++ > >> rules/host-file.in | 13 ++++++ > >> rules/host-file.make | 73 +++++++++++++++++++++++++++++++++++ > > > > What's the host-file needed for? > > The tool calls itself when building. If I don't have it in the cross > build environment the build fails. Just adding it as a host tool was the > easiest solution without investigating the build process and patching > it. This is definitely a cross compiler build issue. Ok. > > The "get" stage can be removed. > > I really need to update the templates for this... > > That's what I did, just use the templates created and adapt the > necessary parts without removing anything else. Good to know this is > good practice. > > > please remove all the stages that are commented out. They are only > > generated in case the default needs to be modified. > > Will take some days, I don't know when I have time for it. No problem. Just repost when you're done. > >> +# vim: ft=make noet > > Because you quoted it anyway. I changed this line in the created make > files. Just changing syntax is only one aspect of make files. Resetting > expandtab (noet aka noexpandtab) is crucial because otherwise you can't > create the tab characters needed in a Makefile. But this should be issue > of another patch for the templates. ;) Please keep the original for now. If we do this, then we should start with the templates and convert all makefiles at once. Regards, Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de
