Dave,

@$(call clean, $(QT4_DIR))
will execute: (from a conceptual point of view)
cd QT4_DIR && make clean

whereas my addition will execute:
cd QT4_DIR && make uninstall

which is _not_ the same.

Also take the moment of execution into consideration. My addition is _only_ exectuted if you call:
"ptxdist clean qt4"
whereas the $(call clean, ...) is executed somewhere in the build process (i.e. in the 'extract' step).

Last but not least, I'm still using ptxdist 1.99.5 which is older. I believe some things have been changed regarding cleaning packages. My patch will only 'uninstall' qt4 from the sysroot and nothing more. If that was what you're looking for, you can use it. If that is not what you're looking for; then what are you looking for?

I needed the patch in the situation where I changed from "qt-static only" to "qt with shared libraries" (or visa versa). In that case some libs were still available in the sysroot (from the previous built) causing some troubles.

Hopefully that clarifies one and another.

Kind regards,
Bart.


On 07/12/2011 11:54 AM, Dave wrote:
Bart,

With regard to a more thorough clean of Qt apps . . .

>In my case the
>  'clean' step in rules/qt4.make looks as this:
>  #
>  ----------------------------------------------------------------------------
>  # Clean
>  #
>  ----------------------------------------------------------------------------
>  qt4_clean:
>       rm -rf $(STATEDIR)/qt4.*
>       rm -rf $(PKGDIR)/qt4_*
>        <at>  cd $(QT4_DIR)&&  $(QT4_PATH) $(MAKE) uninstall
>       rm -rf $(QT4_DIR)
Are suggesting replacing the line:

@$(call clean, $(QT4_DIR))

here, in the original script:
$(STATEDIR)/qt4.extract:
        @$(call targetinfo)
        @$(call clean, $(QT4_DIR))
        @$(call extract, QT4)
        @$(call patchin, QT4)

with the above or just adding your change?

Thank you,
Dave


-- ptxdist mailing list [email protected]

--
--------------------------------------------------
Bart De Vos
Development Engineer
mailto:[email protected]

EIA Electronics
Vluchtenburgstraat  3
B-2630 Aartselaar  (Belgium)
phone   : +32(0)3 870 85 29
fax     : +32(0)3 877 14 72
website : http://www.eia.be/
--------------------------------------------------
Basically, perfect development is impossible.
Development can be fast, good and cheap. Pick two!
— Larry Wall
--------------------------------------------------

-- 
ptxdist mailing list
[email protected]

Reply via email to