On Wednesday 20 July 2011 14:14:53 Robert Schwebel wrote:
> On Wed, Jul 20, 2011 at 10:40:51AM +0200, Alexander Stein wrote:
> > +# Paths and names
> > +#
> > +RSTP_VERSION       := 968d3d40984d0279bce51259ce0e969adc7bda79
> > +RSTP_MD5   := none
> 
> Hmm, I don't like git downloads.
> 
> > +RSTP               := rstp-$(RSTP_VERSION)
> > +RSTP_SUFFIX        := tar.gz
> > +RSTP_URL   :=
> > http://git.kernel.org/?p=linux/kernel/git/shemminger/rstp.git&a=snapshot
> > &h=$(RSTP_VERSION)&sf=tgz
> 
> Releases seem to be here:
> http://www.kernel.org/pub/linux/kernel/people/shemminger/
> 
> but really outdated. Did you trigger Stephen if he has a newer release?
> Other than that, the repository really does contain only 27 commits in
> sum, so I suggest that you start with the version in the download
> directoy and add the necessary patches

bzipped 25MB for 27 commit repository? I seems this is an old 2.4 kernel. I 
didn't talk to Stephen for a new/first release. Dunno if he is willing to do 
so.

> > +RSTP_SOURCE        := 
> > $(SRCDIR)/rstp.git&a=snapshot&h=$(RSTP_VERSION)&sf=tgz
> > +RSTP_DIR   := $(BUILDDIR)/$(RSTP)
> > +RSTP_LICENSE       := GPL-2
> 
> GPLv2

Ok.

> > +
> > +#
> > ------------------------------------------------------------------------
> > ---- +# Prepare
> > +#
> > ------------------------------------------------------------------------
> > ---- +
> > +$(STATEDIR)/rstp.prepare:
> > +   @$(call targetinfo)
> > +   @$(call touch)
> 
> Default stages can be avoided.
> [...]
> Dito.
> [...]
> Dito.
> [...]
> Dito.

Ok. Changed here. Thanks

Alexander

-- 
ptxdist mailing list
[email protected]

Reply via email to