On Tue, Mar 20, 2012 at 08:36:47PM +0100, Bernhard Walle wrote: > When flashbench is not selected in "ptxdist menuconfig", then > $(PTXCONF_FLASHBENCH_MAX_BUFSIZE) is undefined. In that case, the expr > call fails. > > Fix the problem by delaying the evaluation of FLASHBENCH_MAKE_OPT until > it's really needed, i.e. when flashbench has been selected. > > Signed-off-by: Bernhard Walle <bernh...@bwalle.de> > --- > rules/flashbench.make | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rules/flashbench.make b/rules/flashbench.make > index fcb669e..0ef52d1 100644 > --- a/rules/flashbench.make > +++ b/rules/flashbench.make > @@ -31,7 +31,7 @@ FLASHBENCH_LICENSE := GPL v2 > > FLASHBENCH_CONF_TOOL := NO > FLASHBENCH_MAKE_ENV := $(CROSS_ENV) > -FLASHBENCH_MAKE_OPT := CC=$(CROSS_CC) \
Please add a comment here. Otherwise it it not clear why this is needed. Michael > +FLASHBENCH_MAKE_OPT = CC=$(CROSS_CC) \ > EXTRA_CFLAGS=-DMAX_BUFSIZE=$(shell expr 1024 \* 1024 \* > $(PTXCONF_FLASHBENCH_MAX_BUFSIZE)) > > # > ---------------------------------------------------------------------------- > -- > 1.7.9.4 > > > -- > ptxdist mailing list > ptxdist@pengutronix.de > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de