On Tue, Feb 16, 2016 at 04:16:28PM +0100, Michael Olbrich wrote: > On Tue, Feb 16, 2016 at 12:54:33PM +0100, Robert Schwebel wrote: > > On Tue, Feb 16, 2016 at 12:30:35PM +0100, Michael Olbrich wrote: > > > > +# > > > > ---------------------------------------------------------------------------- > > > > +# Prepare > > > > +# > > > > ---------------------------------------------------------------------------- > > > > + > > > > +LINUXPTP_CONF_TOOL := NO > > > > +LINUXPTP_MAKE_OPT := $(CROSS_ENV_PROGS) > > > > > > LINUXPTP_MAKE_OPT := \ > > > $(CROSS_ENV_PROGS) > > > prefix=/usr > > > > The makefile declares prefix with "=" and thus overwrites this, so it > > doesn't have an effect. > > Wrong. Variables set via make arguments (and not environment variables) > overwrite variables set in the makefile.
True, I found the reason why it was ignored. In fact, it wasn't, but we also have to set the variable manually on 'make install', not only on 'make'. > > > > +# > > > > ---------------------------------------------------------------------------- > > > > +# Target-Install > > > > +# > > > > ---------------------------------------------------------------------------- > > > > + > > > > +$(STATEDIR)/linuxptp.targetinstall: > > > > + @$(call targetinfo) > > > > + > > > > + @$(call install_init, linuxptp) > > > > + @$(call install_fixup, linuxptp,PRIORITY,optional) > > > > + @$(call install_fixup, linuxptp,SECTION,base) > > > > + @$(call install_fixup, linuxptp,AUTHOR,"Steffen Trumtrar > > > > <s.trumt...@pengutronix.de>") > > > > + @$(call install_fixup, linuxptp,DESCRIPTION,missing) > > > > + > > > > + @$(call install_copy, linuxptp, 0, 0, 0755, > > > > $(LINUXPTP_DIR)/ptp4l, /sbin/ptp4l) > > > > > > @$(call install_copy, linuxptp, 0, 0, 0755, -, /sbin/ptp4l) > > > > > > for all. Unless there is a reason for prefix=/ ? > > > > The issue above results in the files being installed into /usr/local/* > > anyway, which is the reason why the paths are set explicitly here. > > > > Shall I patch the makefile to accept prefix=? > > > > What do you think is the best place for the binaries: /sbin or > > /usr/sbin? > > I prefer /usr/sbin/. Thanks, I've sent a v2. rsc -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de
