On Fri, Aug 09, 2019 at 12:01:33PM +0200, Alexander Dahl wrote:
> Am Freitag, 9. August 2019, 11:52:03 CEST schrieb Michael Olbrich:
> > On Fri, Aug 09, 2019 at 10:47:44AM +0200, Alexander Dahl wrote:
> > > This includes a lot of security fixes, bug fixes, fixed build issues,
> > > new features, and removed features. Notable for this package:
> > > 
> > > * libuuid support removed
> > > * new systemd service unit
> > > * copied config file from upstream example, changed unpriviledged user
> > > 
> > >   to "daemon" (already exists in ptxdist)
> > 
> > The default user is mosquitto, right? Please introduce that user and copy
> > the example mosquitto.conf to the pkgdir in the install stage. This way it
> > will be used as fallback if no other config is found.
> > Otherwise the config in projectroot/ will become outdated if we're not very
> > careful.
> 
> That came to my mind, but I was not sure if that's desired. Now I know. ;-)
> 
> > > Notes:
> > >     I squeezed the version bump and the new stuff for running the broker
> > >     with systemd in one commit. Let me know if I should split it up.
> 
> I will split up the patch into several patches and resend a v2 then.

Ah, I missed that. Several patches are good.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Reply via email to