Hi, On Tue, Nov 19, 2019 at 10:10:09AM +0100, Guillermo Rodriguez Garcia wrote: > El vie., 15 nov. 2019 a las 21:11, Guillermo Rodriguez Garcia > (<guille.rodrig...@gmail.com>) escribió: > > El viernes, 15 de noviembre de 2019, Michael Olbrich > > <m.olbr...@pengutronix.de> escribió: > >> On Fri, Nov 15, 2019 at 09:51:25AM +0100, Guillermo Rodríguez wrote: > >> > NumPy is the fundamental package for scientific computing with Python. > >> > > >> > Signed-off-by: Guillermo Rodriguez <guille.rodrig...@gmail.com> > >> > --- > >> > v2: Switch to PyPi URL; this removes the dependency on Cython. > >> > v3: Update LICENSE, add LICENSE_FILES > >> > v4: Update LICENSE and LICENSE_FILES with additional licenses > >> > v5: Removed "unknown" from LICENSE > >> > v6: Updated to 1.17.4, added patch to fix cross compilation > >> > > >> > .../numpy-1.17.4/0001-remove-sse2-flag.patch | 21 +++++++ > >> > patches/numpy-1.17.4/series | 1 + > >> > rules/python3-numpy.in | 10 ++++ > >> > rules/python3-numpy.make | 57 +++++++++++++++++++ > >> > 4 files changed, 89 insertions(+) > >> > create mode 100644 patches/numpy-1.17.4/0001-remove-sse2-flag.patch > >> > create mode 100644 patches/numpy-1.17.4/series > >> > create mode 100644 rules/python3-numpy.in > >> > create mode 100644 rules/python3-numpy.make > >> > > >> > diff --git a/patches/numpy-1.17.4/0001-remove-sse2-flag.patch > >> > b/patches/numpy-1.17.4/0001-remove-sse2-flag.patch > >> > new file mode 100644 > >> > index 000000000..e1cb0d878 > >> > --- /dev/null > >> > +++ b/patches/numpy-1.17.4/0001-remove-sse2-flag.patch > >> > @@ -0,0 +1,21 @@ > >> > +Fix cross-compilation for non-Intel targets. > >> > +See: https://github.com/numpy/numpy/issues/14861 > >> > + > >> > +--- > >> > >> Please create a proper patch header. > >> > >> > > > > Can you please let me know what is wrong specifically? The patch was > > generated by quilt and I just added the comment in the first two lines. > > > > I'd prefer to fix whatever is wrong in the patch header rather than > > regenerate the patch using a different method. > > Waiting for feedback on this one in order to generate a new version > that would fix the patch header and remove the explicit > HOST_PYTHON3_SETUPTOOLS dependency.
In general, I'd like to see the From:, Date:, Subject: headers created by git. In this specific case, now that it is fixed upstream, I prefer the exact patch from upstream (including these headers) and with an added comment, that it's ab backport from upstream. That helps when the packages is updated to a new version. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de
