On Fri, Feb 14, 2020 at 01:50:23PM +0100, Michael Olbrich wrote:
> On Wed, Feb 05, 2020 at 11:42:41AM +0100, Ulrich Ölmann wrote:

[...]

> > diff --git a/rules/open62541.make b/rules/open62541.make
> > new file mode 100644
> > index 000000000000..62e030ed3752
> > --- /dev/null
> > +++ b/rules/open62541.make
> > @@ -0,0 +1,140 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2018 by Robert Schwebel <r.schwe...@pengutronix.de>
> > +# Copyright (C) 2019 by Bjoern Esser <b.es...@pengutronix.de>
> > +#
> > +# See CREDITS for details about who has contributed to this project.
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_OPEN62541) += open62541
> > +
> > +#
> > +# Paths and names
> > +#
> > +OPEN62541_VERSION          := 1.0
> > +OPEN62541_MD5                      := b8e02d7310e8b48faf52efc539fa9496
> > +OPEN62541                  := open62541-$(OPEN62541_VERSION)
> > +OPEN62541_SUFFIX           := tar.gz
> > +OPEN62541_URL                      := 
> > https://github.com/open62541/open62541/archive/v$(OPEN62541_VERSION)/$(OPEN62541).$(OPEN62541_SUFFIX)
> > +OPEN62541_SOURCE           := $(SRCDIR)/$(OPEN62541).$(OPEN62541_SUFFIX)
> > +OPEN62541_DIR                      := $(BUILDDIR)/$(OPEN62541)
> > +OPEN62541_LICENSE          := MPL-2.0
> > +OPEN62541_LICENSE_FILES            := 
> > file://LICENSE;md5=815ca599c9df247a0c7f619bab123dad
> > +
> > +OPEN62541_MDNSD_VERSION            := 
> > 4bd993e0fdd06d54c8fd0b8f416cda6a8db18585
> > +OPEN62541_MDNSD_MD5                := 0961fc8dc253753ec8ea157104671498
> > +OPEN62541_MDNSD_URL                := 
> > https://github.com/Pro/mdnsd/archive/$(OPEN62541_MDNSD_VERSION)/open62541-mdnsd-$(OPEN62541_MDNSD_VERSION).tar.gz
> > +OPEN62541_MDNSD_SOURCE             := 
> > $(SRCDIR)/open62541-mdnsd-$(OPEN62541_MDNSD_VERSION).tar.gz
> 
> The suffix deserves a separate variable.

I'm curious why, is it used by anything other than the URL?

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hie...@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Reply via email to