Hi,
On Thu, Feb 10, 2022 at 05:49:19PM +0100, Felix Mellmann wrote:
> On 10.02.22 15:28, rich_ogr...@grayhill.com wrote:
> > It seems that the subject commit breaks ptxd_make_dtb()(for me at least).
> >
> > ptxd_make_dtb()is using the variable dtb_kernel_dir to locate both the
> > dtc script and the dts files.
> > The dtc command needs to be from the build tree yet the dts files will
> > be from the src tree. If building the kernel OOT this causes the dtc
> > command to not be found.
> Ah, thats the reason. I was also wondering why I ran into strange errors. At
> the moment I manually build host-dtc before targetinstall kernel.
And I have a dtc in $PATH so I never noticed that this was broken :-/.
Sorry about that.
> Maybe one could add host-dtc to the dependencies when building the device
> trees along with the kernel?
You can do that for now, but the real fix is to use the correct path.
The dtc is in the kernel build tree not the source tree...
Michael
> > The patch that fixes it for me is below but I cant tell if that breaks
> > the original intent.
> >
> > --- a/scripts/lib/ptxd_make_world_dtb.sh
> > +++ b/scripts/lib/ptxd_make_world_dtb.sh
> > @@ -14,7 +14,7 @@
> >
> > dtb_kernel_dir="${pkg_kernel_src:-${pkg_dir}}"
> >
> > - dtc="${dtb_kernel_dir}/scripts/dtc/dtc"
> > + dtc="${pkg_build_dir}/scripts/dtc/dtc"
> > if [ ! -x "${dtc}" ]; then
> > dtc=dtc
> > fi
> >
> > Rich OGrady
> >
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe"
> > toptxdist-requ...@pengutronix.de
> Best regards,
>
> Felix
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to
> ptxdist-requ...@pengutronix.de
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to
ptxdist-requ...@pengutronix.de
