The short-circuit results in a preference of signed tags over non-signed tags. In BSPs where non-signed tags exist (e.g. DistroKit-2023.09.0) that are newer than the latest signed tag (e.g. DistroKit-2019.12.0), this will always lead to an unnecessarily old tag being used.
Cc: Steffen Trumtrar <s.trumt...@pengutronix.de> Signed-off-by: Roland Hieber <r...@pengutronix.de> --- Steffen, do you still know why you chose a plain "git describe" first? scripts/lib/ptxd_make_vcs_version.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/lib/ptxd_make_vcs_version.sh b/scripts/lib/ptxd_make_vcs_version.sh index 69e486ab31a5..d59e1eba9872 100644 --- a/scripts/lib/ptxd_make_vcs_version.sh +++ b/scripts/lib/ptxd_make_vcs_version.sh @@ -7,8 +7,7 @@ # ptxd_make_vcs_version() { - PTXDIST_VCS_VERSION="$(git describe 2>/dev/null || \ - git describe --always --tags 2>/dev/null)" + PTXDIST_VCS_VERSION="$(git describe --always --tags 2>/dev/null)" if [ -z "${PTXDIST_VCS_VERSION}" ]; then PTXDIST_VCS_VERSION="unknown" -- 2.39.2