Hello Alexander, Am 18.10.23 um 13:38 schrieb Alexander Dahl: > Hello Andreas, > > Am Wed, Oct 18, 2023 at 12:53:58PM +0200 schrieb Andreas Helmcke: >> Hello Alexander, hello Michael, >> >> Am 18.10.23 um 07:54 schrieb Michael Olbrich: >>> On Tue, Oct 17, 2023 at 08:05:11AM +0200, Alexander Dahl wrote: >>>> Hello Andreas, >>>> >>>> first of all, thanks for taking care of this, my remarks below. >>>> >>>> Am Mon, Oct 16, 2023 at 07:07:34PM +0200 schrieb Andreas Helmcke: >>>>> Bugfixes and several changes. e.g. >>>>> - Stronger TLS defaults >>>>> - HTTP/2 Support now as optional module >>>>> >>>>> see: https://www.lighttpd.net/releases/ >>>> >>>> Link: https://www.lighttpd.net/2023/1/3/1.4.68/ >>>> Link: https://www.lighttpd.net/2023/2/10/1.4.69/ >>>> Link: https://www.lighttpd.net/2023/5/10/1.4.70/ >>>> Link: https://www.lighttpd.net/2023/5/27/1.4.71/ >>>> Link: https://www.lighttpd.net/2023/10/6/1.4.72/ >> >> thanks, changed that >> >>>>> Signed-off-by: Andreas Helmcke <ahelm...@ela-soft.com> >>>>> --- >>>>> rules/lighttpd.make | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/rules/lighttpd.make b/rules/lighttpd.make >>>>> index 3aa54a1fb..7b7abf7d2 100644 >>>>> --- a/rules/lighttpd.make >>>>> +++ b/rules/lighttpd.make >>>>> @@ -15,8 +15,8 @@ PACKAGES-$(PTXCONF_LIGHTTPD) += lighttpd >>>>> # >>>>> # Paths and names >>>>> # >>>>> -LIGHTTPD_VERSION := 1.4.67 >>>>> -LIGHTTPD_MD5 := 64822c5061001673162cf9775d91a80b >>>>> +LIGHTTPD_VERSION := 1.4.72 >>>>> +LIGHTTPD_MD5 := 466f9fe131cd7d38d0fe47d2e6a2939d >>>> >>>> Builds fine, but … >>>> >>>> That 1.4.70 in particular needs a little more work on the ptxdist >>>> package, because several modules are not built separate anymore, but >>>> built-in now. This makes some of the LIGHTTPD_MOD_* options in menu >>>> not necessary anymore, and breaks targetinstall if those should have >>>> been installed before, e.g. like this: >>>> >>>> Error: ptxd_lib_install: cannot find library 'lighttpd/mod_indexfile'! >> >> I can not (re)produce your error, but ... > > Interesting. It's one of the modules always installed. Maybe we have > different options set? Comes from these lines: > > 111 # add modules that are always loaded > 112 LIGHTTPD_MODULES_INSTALL := mod_indexfile mod_dirlisting > mod_staticfile $(LIGHTTPD_MODULES-y) > > Please test with PTXCONF_LIGHTTPD_INSTALL_SELECTED_MODULES set and > not set, and compare. I guess you will also find 'mod_staticfile'?
Yes, you are right. I didn't use the option "Only install selected modules". If I fix this by removing mod_indexfile and mod_staticfile (which works) only mod_dirlisting remains in the list of always loaded modules. So it might be a good idea to completely do without a static list of always loaded modules and also make mod_dirlist configurable. Any objections? > >>>> The list of affected modules is in the 1.4.70 announcement. >> >> i have cleaned up the list of modules and removed the now obsolete ones. >> >>>> With 1.4.71 HTTP/2 support is moved to a separate module however and >>>> no longer built-in anymore. Should we introduce a new menu option for >>>> that or let the ptxdist user configure it with >>>> PTXCONF_LIGHTTPD_MOD_EXTRA instead? >>> >>> If it requires additional dependencies then a new option is mandatory. >>> If not, then I don't really care either way. Just leave it as is I guess. >>> >> >> I have decided to create a new menu option because i do think, that >> this is a central/fundamental part and not some exotic stuff so it >> deserves one. > > Thanks. It's good if you can turn it off. Might save some space for > folks who don't want HTTP/2 for whatever reason. > > Greets > Alex > >> >> >>>>> LIGHTTPD := lighttpd-$(LIGHTTPD_VERSION) >>>>> LIGHTTPD_SUFFIX := tar.xz >>>>> LIGHTTPD_URL := >>>>> http://download.lighttpd.net/lighttpd/releases-1.4.x/$(LIGHTTPD).$(LIGHTTPD_SUFFIX) >>>>> -- >>>>> 2.39.2 >>>>> >> >> Andreas >> -- Mit freundlichen Grüßen / Best regards i. A. Andreas Helmcke Hard- und Softwareentwickler / Hard- and Software Developer ela-soft GmbH Entwicklung|GEMOS access / Development|GEMOS access Breitenbachstraße 10 13509 Berlin Germany Phone +49 30 891003-0 Fax +49 30 891003-22 ahelm...@ela-soft.com <mailto:ahelm...@ela-soft.com> http://www.ela-soft.com <http://www.ela-soft.com> ela-soft GmbH / Company of limited liability Sitz der Gesellschaft: Berlin / Place of residence: Berlin Handelsregistereintrag / Commercial Register entry: Amtsgericht Bln Charlottenburg, HRB 114128 B GF: Julius von Resch / Board of directors: Julius von Resch
