On Fri, Mar 15, 2024 at 07:19:24AM +0100, Michael Olbrich wrote: > On Fri, Mar 08, 2024 at 12:57:55PM +0100, Philipp Zabel wrote: > > https://opus-codec.org/demo/opus-1.5/ > > > > New features optional, enabling DRED, deep PLC, and OSCE increases > > the library size by a few MiB. > > > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> > > --- > > rules/opus.in | 20 ++++++++++++++++++-- > > rules/opus.make | 11 +++++++++-- > > 2 files changed, 27 insertions(+), 4 deletions(-) > > > > diff --git a/rules/opus.in b/rules/opus.in > > index 7412eb76a538..3b8e6444cd3e 100644 > > --- a/rules/opus.in > > +++ b/rules/opus.in > > @@ -1,7 +1,23 @@ > > ## SECTION=multimedia_libs > > > > -config OPUS > > +menuconfig OPUS > > tristate > > - prompt "opus" > > + prompt "opus " > > help > > Opus is a totally open, royalty-free, highly versatile audio codec. > > + > > +if OPUS > > + > > +config OPUS_DRED > > + bool > > + prompt "enable deep redundancy (DRED)" > > + > > +config OPUS_DEEP_PLC > > + bool > > + prompt "enable deep packet loss concealment (PLC)" > > + > > +config OPUS_OSCE > > + bool > > + prompt "enable opus speech coding enhancement (OSCE)" > > What's the reason for making these optional? I'd prefer to just hardcode > whatever everybody else is doing unless there is a good reason to make > these optional. And in that case, the options need a help text to help > decide what to choose. I wouldn't know what to do by just looking at these > options.
Enabling the new ML features increases the library size by about 5 MiB (2 MiB for DRED + 1 MiB for deep PLC, and 1 MiB 1.6 MiB for OSCE, according to the blog post). DRED and deep PLC are supposed to improve voice quality under packet loss, OSCE at low bitrates. regards Philipp
