On Wed, May 4, 2011 at 2:57 PM, Israel Hilerio <isra...@microsoft.com> wrote:
> Great, I believe we have consensus. This is the summary of changes we've 
> discussed plus one question/clarification:
>
> 1. IDBDatabase.deleteObjectStore should change to:
> * void deleteObjectStore (in DOMString name) raises (IDBDatabaseException);
>
> 2. IDBDatabase.createObjectStore and IDBDatabase.removeObjectStore will act 
> synchronously and modify IDBDatabase.objectStoreNames.
>
> 3. IDBObjectStore.createIndex and IDBObjectStore.deleteIndex will act 
> synchronously and modify IDBObjectStore.indexNames.
>
> 4. The result value on the IDBRequest returned by IDBFactory.deleteDatabase 
> will be set to undefined when the function executes correctly.
>
> 5. The result value on the IDBRequest returned by IDBObjectStore.clear will 
> be set to undefined when the function executes correctly.

Agreed!

> 6. IDBCursorSync.advance should change to:
> * boolean advance (in int count);
> Returns true if it iterates to a valid position and false if it iterates off 
> of the end.  Also, the result value on the IDBRequest returned by 
> IDBCursor.advance should be the cursor itself if it iterates to a valid 
> position, or null if it iterates off of the end.

Agreed! I just checked in a patch to implement this. So the spec
should now be correct here.

> Additional questions
> -----------------------------
> 7. I don't see in the spec that IDBObjectStoreSync.delete and 
> IDBCursorSync.delete currently return true/false.  I see them both as void 
> functions.  If it was previously agreed to have these functions return 
> Booleans, we should update the spec to reflect it.

Indeed. I checked in a fix for the synchronous API.

> 8. Assuming we update the spec with the change above, I believe you're also 
> suggesting we make the following change:
> * The result value on the IDBRequest returned by IDBObjectStore.delete and 
> IDBCursor.delete holds true or false depending on if the value existed or not.

The asynchronous API already returned true/false as needed since the
algorithms defined in section 5 already returned true/false.

> If we feel good about these changes, I can work with Eliot to update the spec.
> Let me know.

Sounds good to me!

/ Jonas

Reply via email to