Github's new review feature is supported by another new github feature, protected branches. If wanted to, we could combine the two ideas, and only push to protected branches if there is at least one approved review and no review with required changes outstanding.
I think this could be used instead of the "LGTM" label, and can also help with the notion of "drive-by" reviews, since the UI gives you a clear distinction between comments that require changes to be made and comments that do not require changes to be made. For reference: https://help.github.com/articles/about-pull-request-reviews/ Since we've already got support for protected branches, I propose we enable required reviews, and stop using the LGTM label.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://www.redhat.com/mailman/listinfo/pulp-dev
