An extra +1 based on David's good points. --Dana
Dana Walker Associate Software Engineer Red Hat <https://www.redhat.com> <https://red.ht/sig> On Wed, Apr 4, 2018 at 9:12 AM, David Davis <davidda...@redhat.com> wrote: > There are problems I see with the AUTHORS file: > > - It exposes personal info. It makes it easy for headhunters to reap email > addresses. > - Currently it’s out of date and authors are missing (e.g. @dawalker) > - It’s badly formatted. It looks like it’s somewhat alphabetical order but > the last entry is M[1] > - People would prefer not to be in it so we can’t autogenerate/autoupdate > it > - Sometimes we have to revert commits and people often update AUTHORS in > the same commit (e.g. [2]) > - Perhaps most importantly, there already is a contributors page on > github[3] and also you can use git shortlog to get a list of contributors. > > I’m +1 on removing the AUTHORS file. > > [1] https://git.io/vxMLp > [2] https://github.com/pulp/pulp/commit/8b6b11e45a72fffb56e7482a1d91fa4 > <https://github.com/pulp/pulp/commit/8b6b11e45a72fffb56e7482a1d91fa4dbae698e1#diff-3d350169560e75d0cf9fc8e3574a3639R22> > dbae698e1#diff-3d350169560e75d0cf9fc8e3574a3639R22 > <https://github.com/pulp/pulp/commit/8b6b11e45a72fffb56e7482a1d91fa4dbae698e1#diff-3d350169560e75d0cf9fc8e3574a3639R22> > [3] https://github.com/pulp/pulp/graphs/contributors > > > David > > On Wed, Apr 4, 2018 at 8:36 AM, Austin Macdonald <amacd...@redhat.com> > wrote: > >> One reason to keep the AUTHORS file is that it allows contributors to >> specify their contact info instead of just linking to their GitHub page, >> were they might not have an email listed. >> >> I assume this discussion is restricted to pulp/pulp. The plugins are free >> to handle however they prefer. >> >> Personally, I am fine either way. Remove +0, one less file. >> >> >> On Wed, Apr 4, 2018, 05:22 Irina Gulina <igul...@redhat.com> wrote: >> >>> Hello Pulp Team, >>> >>> Recently, I have opened a PR to remove the AUTHORS file [1], and was >>> suggested to bring it up here. >>> Please let us/me know what you think about it. Any feedback will be >>> appreciated. >>> >>> Happy Wednesday, >>> Irina >>> >>> >>> [1] https://github.com/pulp/pulp/pull/3393 >>> >>> _______________________________________________ >>> Pulp-dev mailing list >>> Pulp-dev@redhat.com >>> https://www.redhat.com/mailman/listinfo/pulp-dev >>> >>> >> _______________________________________________ >> Pulp-dev mailing list >> Pulp-dev@redhat.com >> https://www.redhat.com/mailman/listinfo/pulp-dev >> >> > > _______________________________________________ > Pulp-dev mailing list > Pulp-dev@redhat.com > https://www.redhat.com/mailman/listinfo/pulp-dev > >
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://www.redhat.com/mailman/listinfo/pulp-dev
