I have updated the redmine issue[0] to include a page in the contributors guide on "Continuous Integration" as a deliverable. That page will include that quote.
[0] https://pulp.plan.io/issues/3530 On Fri, Apr 6, 2018 at 2:06 PM, Robin Chan <[email protected]> wrote: > Dennis, > > Thanks for putting this together. I don't see any responses on this thread > and take that to mean there were no concerns about this proposal. > > Would this process/responsibility change need to go anywhere? (Side > questions, was this technically a PUP?) > "author of the PR would need to be responsible for making additional PRs > to pulp_file and/or pulp-smash to fix the smash tests" > > I think this is minor enough to skip some process, however I would like to > see the above quote go into the developers guide. A new contributor > shouldn't have to glean through mail list archives to understand this new > responsibility. > > Thanks, > Robin > > On Tue, Mar 27, 2018 at 8:22 PM, Dennis Kliban <[email protected]> wrote: > >> One of the requirements for this plan to work is making sure that pulp, >> pulp_file, and pulp-smash always continue working together. This means that >> any time we have a PR that breaks pulp-smash tests, the author of the PR >> would need to be responsible for making additional PRs to pulp_file and/or >> pulp-smash to fix the smash tests. To enforce this requirement using >> Travis, I have filed 2 tasks[0,1] in redmine that I would like to get >> groomed and added to the sprint. I plan on working on these tasks as I >> introduce a change that will result from resolving issue 3488[2]. >> >> [0] https://pulp.plan.io/issues/3530 >> [1] https://pulp.plan.io/issues/3531 >> [2] https://pulp.plan.io/issues/3488 >> >> On Fri, Mar 23, 2018 at 2:37 PM, Dennis Kliban <[email protected]> >> wrote: >> >>> I've started putting together a Continuous Delivery of Pulp 3 page[0] on >>> our wiki. >>> >>> This page outlines a plan for how we can ensure and prove the quality of >>> Pulp 3 releases by relying on pulp-smash tests and unit tests. >>> >>> This plan enables anyone to improve the quality of Pulp 3 releases >>> through contributions to pulp-smash and unit tests. >>> >>> Please take a look at the plan and provide feedback on this thread or >>> feel free to make edits directly on the page. >>> >>> [0] https://pulp.plan.io/projects/pulp/wiki/Continuous_Delivery_ >>> of_Pulp_3 >>> >>> -Dennis >>> >> >> >> _______________________________________________ >> Pulp-dev mailing list >> [email protected] >> https://www.redhat.com/mailman/listinfo/pulp-dev >> >> >
_______________________________________________ Pulp-dev mailing list [email protected] https://www.redhat.com/mailman/listinfo/pulp-dev
