On Mon, Apr 23, 2018 at 1:45 PM, Jeremy Audet <[email protected]> wrote:
> Thanks for answering my questions, all. > > > > Let's say pulp_file is being tested. Is both it and pulpcore > installed from source? Or is pulpcore installed from egg/wheel? > > > > Yes, we’re testing against source which also allows us to test against > different PRs. Often, a pulpcore change will require a pulp_file change or > vice versa and we just added some functionality recently that actually lets > us test against PRs too.[1] pulp-smash is also running against source or > PRs. IMO, testing against source lets us move faster than testing against > releases. Maybe we can look at switching though once things have stabilized > after the MVP. > > This seems fine in most cases. But when verifying whether a plugin can be > made into a wheel, this seems like a bad strategy. A brand new wheel should > work well when installed alongside other wheels from PyPI, and testing > against from-source installations gives no assurance that this is so. > > That is a great observation. When we automate releasing pulp_file or another plugin to PyPI using Travis, we will make sure to run tests against an already published build of pulpcore. > _______________________________________________ > Pulp-dev mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/pulp-dev > >
_______________________________________________ Pulp-dev mailing list [email protected] https://www.redhat.com/mailman/listinfo/pulp-dev
