For models, bulk_create seems good to me. Endpoints to kick off tasks like
sync that use bulk_create seems fine.

Are you also proposing we have bulk_create for non-task REST API calls?
Should a user be able to POST a list of dictionaries that becomes a set of
Content? I'm open to it, but it seems like it could get ugly.

On Thu, Jun 21, 2018 at 3:54 PM, Brian Bouterse <bbout...@redhat.com> wrote:

> I've run cprofile on some of the sync code for Pulp3 and I've noticed that
> we may have some problems with bulk_create on some of the object types.
>
> Here is a small analysis I did: https://pulp.plan.io/issues/3770#note-2
>
> As an aside, we don't have a bulk add option for
> RepositoryVersion.add_content, which ensures each round trip to the db will
> be for one unit. When you're processing 70K units, that's a lot of trips. I
> don't think we have to add this right now, but to resolve an issue like
> 3770 we may need to.
>
> I do think we should make our models compatible with bulk_create now
> either way.
>
> What do you think?
>
> -Brian
>
> _______________________________________________
> Pulp-dev mailing list
> Pulp-dev@redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
>
_______________________________________________
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

Reply via email to