+1 Dana Walker
Associate Software Engineer Red Hat <https://www.redhat.com> <https://red.ht/sig> On Tue, Jul 10, 2018 at 3:58 PM, Daniel Alley <dal...@redhat.com> wrote: > +1 > > On Tue, Jul 10, 2018 at 3:30 PM, David Davis <davidda...@redhat.com> > wrote: > >> We noticed in Pulp that the 2-master branch has branch protection but >> only to prevent force pushes and deletion. I was wondering if we should >> also add these checks: >> >> - Require an approving review >> - Require status checks (e.g. unit tests, docs test, flake8) >> >> If so, I think we should also do this for all master and 2-master >> branches for all Pulp core repos (where applicable). Does anyone have any >> thoughts or objections? >> >> I’ll leave this discussion open until July 22, 2018. >> >> David >> >> _______________________________________________ >> Pulp-dev mailing list >> Pulp-dev@redhat.com >> https://www.redhat.com/mailman/listinfo/pulp-dev >> >> > > _______________________________________________ > Pulp-dev mailing list > Pulp-dev@redhat.com > https://www.redhat.com/mailman/listinfo/pulp-dev > >
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://www.redhat.com/mailman/listinfo/pulp-dev
