After some feedback, we’re changing the syntax of the keyword for no-issue commits. The original syntax (#noissue) was problematic because the # gets treated as a comment. The new syntax is going to be ‘[noissue]’.
https://github.com/pulp/pulp/pull/3633 David On Tue, Sep 11, 2018 at 10:15 AM David Davis <davidda...@redhat.com> wrote: > I want to announce that commit messages will be validated for PRs against > pulp’s master branch per [0]. This validation will check two things. > > First, the validation script checks that there’s an attached issue in the > commit message. This is to prevent commits not being properly associated > with the issue they've fixed. If you absolutely must commit code without an > issue, add “#noissue” to the commit message. > > Second, issues in commits must be in a state of NEW/ASSIGNED/POST. This is > to prevent commits being associated against issues that have been closed > out and possibly released. > > Lastly, there’s a limitation in that multiple issues must be on separate > lines[1]. See [2] for an example. > > We plan to roll this out to more branches/repos so please submit any > feedback. > > [0] https://pulp.plan.io/issues/3930 > [1] patches welcome! > [2] > https://github.com/pulp/pulp/pull/3614/files#diff-c2a1c5ead0bceb6cb9045af16e489f1eR77 > > David >
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://www.redhat.com/mailman/listinfo/pulp-dev
