Sorry about the hanging sentence fragment! I forgot to delete it while drafting.
On Fri, Feb 1, 2019 at 11:09 AM Daniel Alley <dal...@redhat.com> wrote: > Excellent writeup Tanya! > > There is another change to be aware of as well, which I will mention here: > "ContentSerializer" has been removed and replaced with more specialized > versions -- "NoArtifactContentSerializer", > "SingleArtifactContentSerializer", and > "MultipleArtifactContentSerializer". You now choose which Serializer to > subclass based on the needs of your specific content type. The idea behind > this change is to reduce boilerplate for the former two use cases, which > are both more common than the case of having multiple artifacts associated > with one content object. > > This diff from the pulp_file plugin is a good demonstration of what > changes are necessary: https://github.com/pulp/pulp_file/pull/159/files > > This reduces > > On Fri, Feb 1, 2019 at 10:27 AM Tatiana Tereshchenko <ttere...@redhat.com> > wrote: > >> Hi all, >> >> There was a thread here about namespacing plugins + the idea of dropping >> `pulp_` from the app label. >> Those changes [0] are merged now and some plugins have already been >> updated. >> >> It is not necessary but it's encouraged to update the label of your >> plugin - to drop 'pulp_' part of it if you followed that convention. >> If you intend to change your app label, do so before you start committing >> migrations since the app label is used to name tables in the DB. >> Even if you hesitant to change the label, take a look at the changes in >> viewsets [1], you'd probably like to adjust endpoint_name anyway. >> See pulp_file PR[1] as an example of changes to be made (the __init__.py >> and changes in viewsets are most important, the rest are docs mostly). >> >> Useful for any dev: >> If you use one of the plugins which changed their app label in your dev >> environment, you need to recreate plugin migrations after app label is >> changed. >> E.g. for pulp_file: >> remove everything from the migrations directory of the plugin, e.g. rm >> -rf pulp_file/app/migrations/ >> pulp-manager makemigrations *file* >> pulp-manager migrate >> >> [0] https://pulp.plan.io/issues/4279#note-12 >> [1] https://github.com/pulp/pulp_file/pull/157/ >> _______________________________________________ >> Pulp-dev mailing list >> Pulp-dev@redhat.com >> https://www.redhat.com/mailman/listinfo/pulp-dev >> >
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://www.redhat.com/mailman/listinfo/pulp-dev
