Hi, Thank you for the modifications. I'm more gitlab user than github so I'm not familiar with PR procedure.
It is not clear if the |PULP_SETTINGS| environment is not used any more. In this case the paragraph "Make sure to substitute |Environment=PULP_SETTINGS=/path/to/pulp/server.yaml| with the real location of configuration file <https://docs.pulpproject.org/en/3.0/nightly/installation/configuration.html#id1>." Should be changed by Make sure that the configuration file <https://docs.pulpproject.org/en/3.0/nightly/installation/configuration.html#id1> |/etc/pulp/settings.py |exist. Another difference I see with the ansible provision of my Vagran VM is that -c 'pulpcore.rqconfig' is missing. It is not needed any more ? On the VM I have this in pulp-resource-manager.service : ExecStart=/usr/local/lib/pulp/bin/rq worker \ -w pulpcore.tasking.worker.PulpWorker -n resource-manager@%%h \ --pid=/var/run/pulp-resource-manager/resource-manager.pid And the last difference I see, is that the systemd services are different. There are no worker in /etc/systemd/system/ but an pulp-api service [root@dev-pulp-server ~]# ls /etc/systemd/system/pulp-* /etc/systemd/system/pulp-api.service /etc/systemd/system/pulp-resource-manager.service The worker service seems to be moved to /usr/lib/systemd/system/ [root@dev-pulp-server ~]# ls /usr/lib/systemd/system/pulp-* /usr/lib/systemd/system/pulp-content-app.service /usr/lib/systemd/system/pulp-worker@.service Sincerely Juan On 1/04/19 23:13, Brian Bouterse wrote: > I made a docs issue [0] and a PR to adjust the systemd settings this > [1]. Since dynaconf configures it now, I believe removing this from > the systemd file is the best resolution. > > [0]: https://pulp.plan.io/issues/4622 > [1]: https://github.com/pulp/pulpcore/pull/63 > > Please let us know if there is anything else we can improve on. > > On Fri, Mar 29, 2019 at 1:11 PM Mike DePaulo <mikedep...@redhat.com > <mailto:mikedep...@redhat.com>> wrote: > > On Fri, Mar 29, 2019 at 4:44 AM Juan Cabrera > <juan.cabr...@unamur.be <mailto:juan.cabr...@unamur.be>> wrote: > > At the section about Systemd : > > > https://docs.pulpproject.org/en/3.0/nightly/installation/instructions.html#systemd > > It is said that the default config file is /etc/pulp/server.yaml. > > In the installed VM there is not a > |Environment=PULP_SETTINGS=/path/to/pulp/server.yaml |line in > the pulp-resource-manager.service file and the configuration > file is named `/etc/pulp/settings.py`. Some thing must be > updated in the documentation? > > The file contents in the VM are: > > [root@dev-pulp-server system]# cat > /etc/systemd/system/pulp-resource-manager.service > [Unit] > Description=Pulp Resource Manager > After=network-online.target > Wants=network-online.target > > # This service will break if left running while PostgreSQL > restarts. > BindsTo=postgresql.service > After=postgresql.service > > [Service] > Environment="DJANGO_SETTINGS_MODULE=pulpcore.app.settings" > User=pulp > WorkingDirectory=/var/run/pulp-resource-manager/ > RuntimeDirectory=pulp-resource-manager > ExecStart=/usr/local/lib/pulp/bin/rq worker \ > -w pulpcore.tasking.worker.PulpWorker -n > resource-manager@%%h \ > > --pid=/var/run/pulp-resource-manager/resource-manager.pid > > [Install] > WantedBy=multi-user.target > > Hi Juan, > > Sorry you ran into this issue with our docs. > > I think that specific documentation page[1] is was not > sufficiently updated to reflect the migration to dynaconf. > https://pulpproject.org/2018/09/25/pulp-3-adopts-dynaconf/ > 1. Dynaconf supports multiple formats; .py & .yml included. > 2. The default path /etc/pulp/settings.py is in the codebase > rather than the .service file. The .service file can still > override it. > > Please submit an issue, and a pull request if you can. > https://github.com/pulp/pulpcore/ > > [1] In > contrast, > https://docs.pulpproject.org/en/3.0/nightly/installation/configuration.html > was > updated sufficiently. > > -Mike > _______________________________________________ > Pulp-dev mailing list > Pulp-dev@redhat.com <mailto:Pulp-dev@redhat.com> > https://www.redhat.com/mailman/listinfo/pulp-dev > -- Juan CABRERA Correspondant informatique Département de Mathématiques T. 081724919 juan.cabr...@unamur.be <mailto:juan.cabr...@unamur.be> http://staff.unamur.be/jbcabrer Université de Namur ASBL Rue de Bruxelles 61 - 5000 Namur Belgique Let’s respect the environment together. Only print this message if necessary!
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://www.redhat.com/mailman/listinfo/pulp-dev
