Yes thank you! I read it, and I will strive towards its practices.
On Wed, Oct 2, 2019 at 8:40 AM Tatiana Tereshchenko <ttere...@redhat.com> wrote: > Thanks for sharing! > > Tanya > > On Tue, Oct 1, 2019 at 1:52 PM David Davis <davidda...@redhat.com> wrote: > >> I've been reading through Google's Code Reviewer Guide and I've found it >> rather interesting. While reviewing code may seem pretty basic, I have >> found a couple rather insightful points in their guide. One example is that >> they recommend sharing positive feedback while reviewing code--too often >> reviewers focus on what needs to be fixed in PRs. If you have some time, I >> recommend reading through it. >> >> https://google.github.io/eng-practices/review/reviewer/ >> >> By the way, they use a term CL which comes from their use of a >> Perforce-like version control system. They define it here under Terminology: >> >> https://google.github.io/eng-practices/ >> >> David >> _______________________________________________ >> Pulp-dev mailing list >> Pulp-dev@redhat.com >> https://www.redhat.com/mailman/listinfo/pulp-dev >> > _______________________________________________ > Pulp-dev mailing list > Pulp-dev@redhat.com > https://www.redhat.com/mailman/listinfo/pulp-dev >
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://www.redhat.com/mailman/listinfo/pulp-dev
