Since we decided to move forwards with this, here are the PRs: https://pulp.plan.io/issues/5580#note-8
On Fri, Oct 18, 2019 at 5:29 AM Ina Panova <ipan...@redhat.com> wrote: > +1 let's talk about this more next week. > > > -------- > Regards, > > Ina Panova > Senior Software Engineer| Pulp| Red Hat Inc. > > "Do not go where the path may lead, > go instead where there is no path and leave a trail." > > > On Thu, Oct 17, 2019 at 7:25 PM David Davis <davidda...@redhat.com> wrote: > >> I agree that it makes sense to talk about it next week. I have a few >> concerns both in favor and against merging the repos that are not expressed >> on the issue. Let's remove it off the sprint for now. >> >> David >> >> >> On Thu, Oct 17, 2019 at 1:13 PM Brian Bouterse <bmbou...@redhat.com> >> wrote: >> >>> Thank you for sharing your concerns. Let's think it over more. >>> >>> >>> On Thu, Oct 17, 2019 at 12:39 PM Tatiana Tereshchenko < >>> ttere...@redhat.com> wrote: >>> >>>> Do I understand correctly, that the suggestion is not to have versioned >>>> api at all but document some conventions/expectations between pulpcore >>>> releases and plugin API? >>>> >>> We could version pulpcore.plugin as 0.1 as we were. It's just that >>> plugins can't use setuptools tooling to declare their compatibility. The >>> pulp plugin loader could check plugin minimum/maximum versions declared at >>> runtime though and disinclude plugins that aren't compatible with the >>> running pulpcore version. That would be a neat upgrade experience actually >>> whenever the pulpcore.plugin version goes to 0.2 which would be backwards >>> incompatible. >>> >>> >>>> I wonder if there is still a benefit to keep it as a separate package >>>> and as-is. >>>> >>> There is a benefit to keeping it as-is. What we have now is slightly >>> more awesome. The amount of problems it creates though is a lot. >>> >>> I understand that now we need to release both at the same time, however >>>> we are in active development now and when things are more stable we might >>>> benefit from having it separate. >>>> >>> The code imports heavily across the package lines, so I think we'll >>> always have to co-release, which is the pain because you have to wait a >>> long time for Travis to fully retest + release. >>> >>>> >>>> It sounds like we are back to pulp2 case, where we would need to >>>> release the core if any plugin api changes are needed, just this time we >>>> organised code better. >>>> >>> We could still have a versioned pulpcore.plugin which would be much >>> stronger. >>> >>> >>>> Since we have a meetup next week, does it make sense to discuss it >>>> there? Plans on what we want or expect to support and what kind of changes >>>> we foresee in this area? Where the plugin api versioning will benefit us? >>>> I see many +1s, so it might not worth a discussion and maybe I'm the >>>> only one who is concerned. >>>> >>> I definitely want to talk about concerns. It's a big change. We can >>> delay some to think it over at least, call for more feedback. I was hoping >>> to keep discussion on the list though, even with us meeting in person. The >>> list I think gives inclusivity and record to those who cannot join. We can >>> remove from sprint now? >>> >>> >>>> Tanya >>>> >>>> >>>> On Thu, Oct 17, 2019 at 5:58 PM David Davis <davidda...@redhat.com> >>>> wrote: >>>> >>>>> Done. >>>>> >>>>> David >>>>> >>>>> >>>>> On Thu, Oct 17, 2019 at 11:49 AM Brian Bouterse <bmbou...@redhat.com> >>>>> wrote: >>>>> >>>>>> Yes the issue is here: https://pulp.plan.io/issues/5580 >>>>>> >>>>>> If someone else can groom, I'm +1 to adding to sprint and labelling >>>>>> 3.0 blocker. >>>>>> >>>>>> On Thu, Oct 17, 2019 at 11:01 AM David Davis <davidda...@redhat.com> >>>>>> wrote: >>>>>> >>>>>>> Any chance we open an issue and get this on the sprint so that we >>>>>>> can maybe release this change in RC8? >>>>>>> >>>>>>> David >>>>>>> >>>>>>> >>>>>>> On Thu, Oct 17, 2019 at 10:49 AM Mike DePaulo <mikedep...@redhat.com> >>>>>>> wrote: >>>>>>> >>>>>>>> On Thu, Oct 17, 2019 at 10:25 AM Brian Bouterse < >>>>>>>> bmbou...@redhat.com> wrote: >>>>>>>> >>>>>>>>> I put some responses inline. I'm interested in what you think. >>>>>>>>> >>>>>>>>> On Thu, Oct 17, 2019 at 10:10 AM Mike DePaulo < >>>>>>>>> mikedep...@redhat.com> wrote: >>>>>>>>> >>>>>>>>>> Q: Will both pulpcore & pulpcore-plugin be published on PyPI as 1 >>>>>>>>>> package, or as 2? >>>>>>>>>> >>>>>>>>> I had imagined it would be 1. Users wouldn't be able to receive >>>>>>>>> pulpcore.plugin except through an install of the pulpcore==3.y.z >>>>>>>>> itself. >>>>>>>>> >>>>>>>> >>>>>>>> Great, that makes things easier for users' manual installs, and >>>>>>>> easier for containers/packaging. >>>>>>>> >>>>>>>> >>>>>>>>>> If so, how will you pip install from a pip VCS URL >>>>>>>>>> <https://pip.pypa.io/en/stable/reference/pip_install/#id32>? >>>>>>>>>> With #egg=pulpcore , and then #egg=pulpcore-plugin ? >>>>>>>>>> >>>>>>>>> You wouldn't perform the second one anymore. >>>>>>>>> >>>>>>>> >>>>>>>> Great, that makes things easier for users' manual installs, and >>>>>>>> easier for containers/packaging. >>>>>>>> >>>>>>>> -Mike >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>>> -Mike >>>>>>>>>> >>>>>>>>>> On Thu, Oct 17, 2019 at 5:17 AM Simon Baatz <gmbno...@gmail.com> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> +1 >>>>>>>>>>> >>>>>>>>>>> On Wed, Oct 16, 2019 at 03:50:54PM -0400, Mike DePaulo wrote: >>>>>>>>>>> > +1. >>>>>>>>>>> > >>>>>>>>>>> > On Wed, Oct 16, 2019 at 3:26 PM Pavel Picka <[1] >>>>>>>>>>> ppi...@redhat.com> >>>>>>>>>>> > wrote: >>>>>>>>>>> > >>>>>>>>>>> > +1 >>>>>>>>>>> > >>>>>>>>>>> > On Wed, Oct 16, 2019 at 9:23 PM Dana Walker <[2] >>>>>>>>>>> dawal...@redhat.com> >>>>>>>>>>> > wrote: >>>>>>>>>>> > >>>>>>>>>>> > +1, more straightforward >>>>>>>>>>> > >>>>>>>>>>> > Dana Walker >>>>>>>>>>> > >>>>>>>>>>> > She / Her / Hers >>>>>>>>>>> > >>>>>>>>>>> > Software Engineer, Pulp Project >>>>>>>>>>> > >>>>>>>>>>> > [3]Red Hat >>>>>>>>>>> > >>>>>>>>>>> > [4]dawal...@redhat.com >>>>>>>>>>> > [5][Logo-RedHat-Email.png] >>>>>>>>>>> > >>>>>>>>>>> > On Wed, Oct 16, 2019 at 2:55 PM David Davis <[6] >>>>>>>>>>> davidda...@redhat.com> >>>>>>>>>>> > wrote: >>>>>>>>>>> > >>>>>>>>>>> > +1 >>>>>>>>>>> > David >>>>>>>>>>> > >>>>>>>>>>> > On Wed, Oct 16, 2019 at 2:38 PM Daniel Alley <[7] >>>>>>>>>>> dal...@redhat.com> >>>>>>>>>>> > wrote: >>>>>>>>>>> > >>>>>>>>>>> > Very Large +1 >>>>>>>>>>> > >>>>>>>>>>> > On Wed, Oct 16, 2019 at 2:10 PM Brian Bouterse <[8] >>>>>>>>>>> bmbou...@redhat.com> >>>>>>>>>>> > wrote: >>>>>>>>>>> > >>>>>>>>>>> > Having just released RC7, there are a variety of problems >>>>>>>>>>> we are >>>>>>>>>>> > dealing with as a result of having pulpcore and >>>>>>>>>>> pulpcore-plugin being >>>>>>>>>>> > in separate repos. @daviddavis and I were talking, and we >>>>>>>>>>> want to ask >>>>>>>>>>> > for feedback on merging the code from pulpcore-plugin into >>>>>>>>>>> pulpcore. >>>>>>>>>>> > I wrote this up as an issue here: [9] >>>>>>>>>>> https://pulp.plan.io/issues/5580 >>>>>>>>>>> > Thanks! >>>>>>>>>>> > Brian >>>>>>>>>>> > >>>>>>>>>>> > _______________________________________________ >>>>>>>>>>> > Pulp-dev mailing list >>>>>>>>>>> > [10]Pulp-dev@redhat.com >>>>>>>>>>> > [11]https://www.redhat.com/mailman/listinfo/pulp-dev >>>>>>>>>>> > >>>>>>>>>>> > _______________________________________________ >>>>>>>>>>> > Pulp-dev mailing list >>>>>>>>>>> > [12]Pulp-dev@redhat.com >>>>>>>>>>> > [13]https://www.redhat.com/mailman/listinfo/pulp-dev >>>>>>>>>>> > >>>>>>>>>>> > _______________________________________________ >>>>>>>>>>> > Pulp-dev mailing list >>>>>>>>>>> > [14]Pulp-dev@redhat.com >>>>>>>>>>> > [15]https://www.redhat.com/mailman/listinfo/pulp-dev >>>>>>>>>>> > >>>>>>>>>>> > _______________________________________________ >>>>>>>>>>> > Pulp-dev mailing list >>>>>>>>>>> > [16]Pulp-dev@redhat.com >>>>>>>>>>> > [17]https://www.redhat.com/mailman/listinfo/pulp-dev >>>>>>>>>>> > >>>>>>>>>>> > -- >>>>>>>>>>> > >>>>>>>>>>> > Pavel Picka >>>>>>>>>>> > Red Hat >>>>>>>>>>> > >>>>>>>>>>> > _______________________________________________ >>>>>>>>>>> > Pulp-dev mailing list >>>>>>>>>>> > [18]Pulp-dev@redhat.com >>>>>>>>>>> > [19]https://www.redhat.com/mailman/listinfo/pulp-dev >>>>>>>>>>> > >>>>>>>>>>> > -- >>>>>>>>>>> > >>>>>>>>>>> > Mike DePaulo >>>>>>>>>>> > >>>>>>>>>>> > He / Him / His >>>>>>>>>>> > >>>>>>>>>>> > Service Reliability Engineer, Pulp >>>>>>>>>>> > >>>>>>>>>>> > [20]Red Hat >>>>>>>>>>> > >>>>>>>>>>> > IM: mikedep333 >>>>>>>>>>> > >>>>>>>>>>> > GPG: 51745404 >>>>>>>>>>> > [21][Logo-RedHat-Email.png] >>>>>>>>>>> > >>>>>>>>>>> > References >>>>>>>>>>> > >>>>>>>>>>> > 1. mailto:ppi...@redhat.com >>>>>>>>>>> > 2. mailto:dawal...@redhat.com >>>>>>>>>>> > 3. https://www.redhat.com/ >>>>>>>>>>> > 4. mailto:dawal...@redhat.com >>>>>>>>>>> > 5. https://www.redhat.com/ >>>>>>>>>>> > 6. mailto:davidda...@redhat.com >>>>>>>>>>> > 7. mailto:dal...@redhat.com >>>>>>>>>>> > 8. mailto:bmbou...@redhat.com >>>>>>>>>>> > 9. https://pulp.plan.io/issues/5580 >>>>>>>>>>> > 10. mailto:Pulp-dev@redhat.com >>>>>>>>>>> > 11. https://www.redhat.com/mailman/listinfo/pulp-dev >>>>>>>>>>> > 12. mailto:Pulp-dev@redhat.com >>>>>>>>>>> > 13. https://www.redhat.com/mailman/listinfo/pulp-dev >>>>>>>>>>> > 14. mailto:Pulp-dev@redhat.com >>>>>>>>>>> > 15. https://www.redhat.com/mailman/listinfo/pulp-dev >>>>>>>>>>> > 16. mailto:Pulp-dev@redhat.com >>>>>>>>>>> > 17. https://www.redhat.com/mailman/listinfo/pulp-dev >>>>>>>>>>> > 18. mailto:Pulp-dev@redhat.com >>>>>>>>>>> > 19. https://www.redhat.com/mailman/listinfo/pulp-dev >>>>>>>>>>> > 20. https://www.redhat.com/ >>>>>>>>>>> > 21. https://www.redhat.com/ >>>>>>>>>>> >>>>>>>>>>> > _______________________________________________ >>>>>>>>>>> > Pulp-dev mailing list >>>>>>>>>>> > Pulp-dev@redhat.com >>>>>>>>>>> > https://www.redhat.com/mailman/listinfo/pulp-dev >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> >>>>>>>>>> Mike DePaulo >>>>>>>>>> >>>>>>>>>> He / Him / His >>>>>>>>>> >>>>>>>>>> Service Reliability Engineer, Pulp >>>>>>>>>> >>>>>>>>>> Red Hat <https://www.redhat.com/> >>>>>>>>>> >>>>>>>>>> IM: mikedep333 >>>>>>>>>> >>>>>>>>>> GPG: 51745404 >>>>>>>>>> <https://www.redhat.com/> >>>>>>>>>> _______________________________________________ >>>>>>>>>> Pulp-dev mailing list >>>>>>>>>> Pulp-dev@redhat.com >>>>>>>>>> https://www.redhat.com/mailman/listinfo/pulp-dev >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> >>>>>>>> Mike DePaulo >>>>>>>> >>>>>>>> He / Him / His >>>>>>>> >>>>>>>> Service Reliability Engineer, Pulp >>>>>>>> >>>>>>>> Red Hat <https://www.redhat.com/> >>>>>>>> >>>>>>>> IM: mikedep333 >>>>>>>> >>>>>>>> GPG: 51745404 >>>>>>>> <https://www.redhat.com/> >>>>>>>> _______________________________________________ >>>>>>>> Pulp-dev mailing list >>>>>>>> Pulp-dev@redhat.com >>>>>>>> https://www.redhat.com/mailman/listinfo/pulp-dev >>>>>>>> >>>>>>> _______________________________________________ >>>>> Pulp-dev mailing list >>>>> Pulp-dev@redhat.com >>>>> https://www.redhat.com/mailman/listinfo/pulp-dev >>>>> >>>> _______________________________________________ >>>> Pulp-dev mailing list >>>> Pulp-dev@redhat.com >>>> https://www.redhat.com/mailman/listinfo/pulp-dev >>>> >>> _______________________________________________ >>> Pulp-dev mailing list >>> Pulp-dev@redhat.com >>> https://www.redhat.com/mailman/listinfo/pulp-dev >>> >> _______________________________________________ >> Pulp-dev mailing list >> Pulp-dev@redhat.com >> https://www.redhat.com/mailman/listinfo/pulp-dev >> > _______________________________________________ > Pulp-dev mailing list > Pulp-dev@redhat.com > https://www.redhat.com/mailman/listinfo/pulp-dev >
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://www.redhat.com/mailman/listinfo/pulp-dev
