David, I approved your pulp_file PR, but I do not have perms for it to be an actual approving review.
It looks like pulpcore is the only repo with certguard in its CI now. Also: Thank you Fabricio for making pulp-certguard configurable in template_config.yml (the "additional_plugins" var). -Mike On Fri, Nov 15, 2019 at 11:51 AM David Davis <davidda...@redhat.com> wrote: > Nevermind, I figured it out. Here's the pulp_file PR. I'll investigate the > other plugins too. > > https://github.com/pulp/pulp_file/pull/315 > > David > > > On Fri, Nov 15, 2019 at 11:44 AM David Davis <davidda...@redhat.com> > wrote: > >> Are you sure the problem needs to be fixed in plugin_template? I looked >> but didn't see anywhere that might be including pulp-certguard. I think it >> may be in the containers. >> >> David >> >> >> On Fri, Nov 15, 2019 at 11:26 AM Brian Bouterse <bmbou...@redhat.com> >> wrote: >> >>> I've been making PRs to release pulp_file, and what I realized (after >>> @dkliban told me) was that we have a circular release dependency. We can't >>> release pulp-certguard (see the failed build [0]) without pulp_file being >>> released, and we can't release pulp_file without pulp-cerguard being >>> released [1]. >>> >>> This is also going to prevent all plugins from releasing because the >>> plugin_tempalte is what is creating this circular dependency. >>> >>> I'm on PTO, but I wanted to relay this info. I recommend we remove >>> pulp-certguard entirely from the plugin_template and then apply that to all >>> of the plugins. If someone is able to do that today, that would be helpful, >>> I think. >>> >>> [0]: https://travis-ci.org/pulp/pulp-certguard/builds/612040760 >>> [1]: https://github.com/pulp/pulp_file/pull/313 >>> >>> All the best, >>> Brian >>> _______________________________________________ >>> Pulp-dev mailing list >>> Pulp-dev@redhat.com >>> https://www.redhat.com/mailman/listinfo/pulp-dev >>> >> _______________________________________________ > Pulp-dev mailing list > Pulp-dev@redhat.com > https://www.redhat.com/mailman/listinfo/pulp-dev > -- Mike DePaulo He / Him / His Service Reliability Engineer, Pulp Red Hat <https://www.redhat.com/> IM: mikedep333 GPG: 51745404 <https://www.redhat.com/>
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://www.redhat.com/mailman/listinfo/pulp-dev
