It would be great if we could automate this part as well. As per responsibility, I think both reviewer and author should share it. Obviously if this is a new contributor, as Tanya mentioned, then reviewer should make sure the label is properly placed if needed.
-------- Regards, Ina Panova Senior Software Engineer| Pulp| Red Hat Inc. "Do not go where the path may lead, go instead where there is no path and leave a trail." On Wed, Mar 18, 2020 at 1:36 PM David Davis <[email protected]> wrote: > I think it would be easy to automatically apply the cherry pick label with > Github Actions. Github Actions has all sorts of events that can trigger > workflows including opening a new PR[0]. This workflow could also > automatically move the redmine issue to POST and comment with the PR too. > > [0] > https://help.github.com/en/actions/reference/events-that-trigger-workflows#pull-request-event-pull_request > > David > > > On Wed, Mar 18, 2020 at 6:02 AM Tatiana Tereshchenko <[email protected]> > wrote: > >> I believe it's the responsibility of both the author and the PR reviewer. >> >> If it's a one-time contribution from someone, then the PR reviewer is >> likely the one who is aware whether the cherry-pick should be done or not. >> However in the majority of cases, we have regular contributors and they >> are aware of the process. Depending on the fix, they might be in a better >> position to say whether it's worth cherry-picking, if the cherry-pick will >> be clean or not. >> >> Alternatively, can we automate it? When PR is open, look at the referred >> redmine issue and check its tracker, if it's an "issue", mark PR as the one >> to be cherry-picked, so reviewer can unset it if it's undesirable for >> whatever reason. >> >> Tanya >> >> On Tue, Mar 17, 2020 at 9:43 PM David Davis <[email protected]> >> wrote: >> >>> Today we missed a change that could have maybe have gone out with the >>> 3.2 release. It stemmed from a lack of clarity around whose responsibility >>> it is to label PRs with the cherry pick label. I think the general >>> agreement is that it's ultimately the responsibility of the PR reviewer to >>> add this label to the PR. I'm interested to see if there are any other >>> thoughts or objections. Here is a PR I've opened as a proposal: >>> >>> https://github.com/pulp/pulpcore/pull/592 >>> >>> David >>> _______________________________________________ >>> Pulp-dev mailing list >>> [email protected] >>> https://www.redhat.com/mailman/listinfo/pulp-dev >>> >> _______________________________________________ > Pulp-dev mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/pulp-dev >
_______________________________________________ Pulp-dev mailing list [email protected] https://www.redhat.com/mailman/listinfo/pulp-dev
