This is great. Thank you for working on it. As a next step, would it make sense to create a branch and then try to deploy a new temporary tag from that branch? Then maybe we can test a plugin (eg pulp_npm) against this new image and see what breaks.
David On Mon, Apr 26, 2021 at 5:01 PM Fabricio Aguiar <fagui...@redhat.com> wrote: > I started this POC: https://github.com/pulp/pulp-oci-images/pull/73 > It enables https on the single container, once merged, the CI for every > plugin will run the functional tests using https. > Probably it would break the majority of the CIs, we need to discuss when > is the best moment to merge this PR or discuss alternatives > > Best regards, > Fabricio Aguiar > Software Engineer, Pulp Project > Red Hat Brazil - Latam <https://www.redhat.com/> > +55 22 999000595 > > > > On Tue, Feb 9, 2021 at 10:55 AM Fabricio Aguiar <fagui...@redhat.com> > wrote: > >> Our nginx conf only supports http now: >> https://github.com/pulp/pulp-oci-images/blob/latest/assets/nginx.conf#L15 >> For not breaking all plugins, I believe we can build a new CI image that >> supports https. >> Maybe a template_config parameter - test_https: true would switch the >> images >> >> Best regards, >> Fabricio Aguiar >> Software Engineer, Pulp Project >> Red Hat Brazil - Latam <https://www.redhat.com/> >> +55 22 999000595 >> >> >> >> On Tue, Feb 9, 2021 at 5:16 AM Matthias Dellweg <mdell...@redhat.com> >> wrote: >> >>> I believe this is at least solving the problem partially: >>> >>> https://github.com/pulp/pulp-smash/pull/1251 >>> >>> On Mon, Feb 8, 2021 at 9:48 PM Brian Bouterse <bmbou...@redhat.com> >>> wrote: >>> >>>> I believe all of our plugins (and CI) require HTTP and do not work with >>>> HTTPS. I'm not well versed in what needs to be done to fix this, but I >>>> think we should fix it. >>>> >>>> Can the CI group have a 30 min call to talk over what needs to be done? >>>> Or maybe share some info here? >>>> >>>> The main issue I'm aware of is that the tests are not prepared to trust >>>> an https certificate that is self-signed. I'm not exactly sure where we can >>>> change that in one place either. >>>> >>>> Thanks! >>>> Brian >>>> >>>> >>>> >>>> _______________________________________________ >>>> Pulp-dev mailing list >>>> Pulp-dev@redhat.com >>>> https://www.redhat.com/mailman/listinfo/pulp-dev >>>> >>> _______________________________________________ >>> Pulp-dev mailing list >>> Pulp-dev@redhat.com >>> https://www.redhat.com/mailman/listinfo/pulp-dev >>> >> _______________________________________________ > Pulp-dev mailing list > Pulp-dev@redhat.com > https://listman.redhat.com/mailman/listinfo/pulp-dev >
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://listman.redhat.com/mailman/listinfo/pulp-dev