On 3/26/21 4:16 PM, Grant Gainey wrote:
On Fri, Mar 26, 2021 at 4:01 PM Justin Sherrill <jsher...@redhat.com <mailto:jsher...@redhat.com>> wrote:Hello! I had some questions for the timeout options here: https://docs.pulpproject.org/pulp_rpm/restapi.html#operation/remotes_rpm_rpm_create <https://docs.pulpproject.org/pulp_rpm/restapi.html#operation/remotes_rpm_rpm_create>\ 1. Do the default values come from https://docs.aiohttp.org/en/stable/client_reference.html <https://docs.aiohttp.org/en/stable/client_reference.html> or are they set in pulp (and if so what are they?)Pulp defers to aiohttp - see https://github.com/pulp/pulpcore/pull/1026#discussion_r533710092 <https://github.com/pulp/pulpcore/pull/1026#discussion_r533710092> for the discussion on that.2. Two of those aiohttp settings look deprecated (read_timeout & conn_timeout), but are exposed in pulp, is that intentional ?It is intentional, in that they were in the original issue, and I didn't notice they were deprecated when writing the code, alas :(
Apologies, i was looking at the wrong class (ClientSession), these options map straight to the ClientTimeout class and are NOT deprecated. Thanks for the clarification!
Justin
G -- Grant Gainey Principal Software Engineer, Red Hat System Management Engineering
_______________________________________________ Pulp-list mailing list Pulp-list@redhat.com https://listman.redhat.com/mailman/listinfo/pulp-list
