2011/9/5 Colin Guthrie <gm...@colin.guthr.ie>: > Hi, > > I added a couple blocker bugs to 1.0 after Lennart's comments.
Good work. Nice to have a bit of a clear path to 1.0. > Nothing too big really - see the tracking bug: > https://bugs.freedesktop.org/show_bug.cgi?id=40193 > > There are a few other minor things that I will take care of and push > later today most likely (didn't seem worth creating a bug. > > But if anyone else beats me to it these are: > > * module-match should require pcre support, not be optional (i.e. it > should behave consistently, and not be build-time feature specific > (Tanu, you may have comments about this? Want to overrule this > recommendation?) I don't understand this quite. Alls I'd like to add is that pcre is required on win32 to build module-match, because libc doesn't have posix regex functionality. > * Generic Lennart comment: the PA_LOG_FD stuff I really don't like. Any > ideas on how to make it Lennart-compatible? Perhaps the concept is just > one he doesn't like, but as it was developed by some embedded folks > (Intel I believe) it's clearly useful to some people. The PA_LOG_FD stuff was in the midst of development (quite a lot of patch proposal rounds) at the time of the last meeting. Lennart specifically said that he had no objections to the general idea, but he had lots of minor issues with the approach taken. (At the table was vincent's first stab at the patch, were we had already put some comments on list on) All the minor issues were fixed and the patch was committed. In this light I fail to see how we should make effort to make that functionality Lennart-compatible in this stage of development. > That's all folks. Nothing too crazy and all fixable in a couple days I > think :) > > Col Maarten _______________________________________________ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
