On Tue, 2012-06-05 at 13:53 +0200, [email protected] wrote: > On Tue, Jun 05, 2012 at 01:36:58PM +0200, David Henningsson wrote: > > On 06/04/2012 07:35 PM, poljar wrote: > > >+static void connect_ports(struct userdata *u, void > > >*sink_or_source_new_data, pa_direction_t direction) { > > >+ union { > > >+ pa_sink_new_data *sink_new_data; > > >+ pa_source_new_data *source_new_data; > > >+ } data; > > > > Using unions this way is error-prone IMO - just use two different > > pointers "sink_new_data" and "source_new_data", no point in > > encapsulating them into "data". > > > > This was a suggestion by Tanu, I don't know how and why this should be > error-prone.
Since there were no further comments from David, I assume that he doesn't have too much against this patch, so I've pushed it now. -- Tanu _______________________________________________ pulseaudio-discuss mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
