Dear Flavio,

thank you for your patches. As you are asked to resend anyway, here are
some nitpicks.


Am Mittwoch, den 14.11.2012, 15:19 -0200 schrieb Flavio Ceolin:
> This patch makes possible to set more than one volume factor.  The

s,makes,makes it,

Also starting a commit message with »This patch« is redundant most of
the time.

> real value of the volume_factor will be the multiplication of these
> values.

Something like »Implement setting of more than one volume factor. …« or
so could also be used.

> ---
>  src/pulsecore/sink-input.c | 172 
> ++++++++++++++++++++++++++++++++++++++-------
>  src/pulsecore/sink-input.h |  19 +++--
>  2 files changed, 158 insertions(+), 33 deletions(-)

[…]


Thanks,

Paul

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Reply via email to