Heya,

On Sep 22, 2008, at 5:01 PM, Nick Thompson wrote:

Where should I start looking to address this?

There appears to be an extraneous assert in sink.c. Removal of this assert allows module-null-sink to function correctly, playing a sine wave into a null sink and recoding the monitor-source for the sink via <sink-name>.monitor yields a sine wave with no glitches.

Here is the change made:

--------------------------
diff -ruN pulseaudio-0.9.12-r11.orig/pulseaudio-0.9.12/src/pulsecore/ sink.c pulseaudio-0.9.12-r11/pulseaudio-0.9.12/src/pulsecore/sink.c --- pulseaudio-0.9.12-r11.orig/src/pulsecore/sink.c 2008-09-23 10:14:55.000000000 -0700 +++ pulseaudio-0.9.12-r11/src/pulsecore/sink.c 2008-09-23 10:18:25.000000000 -0700
@@ -629,7 +629,9 @@

     pa_sink_ref(s);

-    pa_assert(!s->thread_info.rewind_requested);
+    /* this assertion seems to be unecessary, remove */
+    /* pa_assert(!s->thread_info.rewind_requested); */
+
     pa_assert(s->thread_info.rewind_nbytes == 0);

     if (length <= 0)
-----------------------
_______________________________________________
pulseaudio-discuss mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss

Reply via email to