Forgot to say but I have this patch lined up too to make the
filter.want=equalizer-sink stuff work.
Better argument standardisation across the board welcome. Happy for any
suggestions on naming conventions or leaving it as it is.
Also, I had to apply this patch to equalizer-sink to prevent it from
crashing the server on unload:
diff --git a/src/modules/module-equalizer-sink.c
b/src/modules/module-equalizer-sink.c
index 0bbb23a..611f7dd 100644
--- a/src/modules/module-equalizer-sink.c
+++ b/src/modules/module-equalizer-sink.c
@@ -1286,7 +1286,7 @@ void pa__done(pa_module*m) {
save_state(u);
- dbus_done(u);
+ //dbus_done(u);
for(c = 0; c < u->channels; ++c)
pa_xfree(u->base_profiles[c]);
I mentioned this in another thread... hopefully someone more familiar
with dbus can take a look at the underlying issue here :)
Col
--
Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/
Day Job:
Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
Mageia Contributor [http://www.mageia.org/]
PulseAudio Hacker [http://www.pulseaudio.org/]
Trac Hacker [http://trac.edgewall.org/]
>From a11b6cd5a9c9a713d7e1468151627c2c659835d3 Mon Sep 17 00:00:00 2001
From: Colin Guthrie <co...@mageia.org>
Date: Thu, 14 Apr 2011 13:00:58 +0200
Subject: [PATCH] equalizer: Use sink_master as the module argument rather than just master.
This brings more uniformity to arguments to match module-echo-cancel
(which needs both sink and source masters, hence the disambiguation).
This will allow other modules to load filters in a more uniform way
in the future without kludges to deal with variation in arguments.
---
src/modules/module-equalizer-sink.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/modules/module-equalizer-sink.c b/src/modules/module-equalizer-sink.c
index bb350c3..0bbb23a 100644
--- a/src/modules/module-equalizer-sink.c
+++ b/src/modules/module-equalizer-sink.c
@@ -79,7 +79,7 @@ PA_MODULE_LOAD_ONCE(FALSE);
PA_MODULE_USAGE(
_("sink_name=<name of the sink> "
"sink_properties=<properties for the sink> "
- "master=<sink to connect to> "
+ "sink_master=<sink to connect to> "
"format=<sample format> "
"rate=<sample rate> "
"channels=<number of channels> "
@@ -133,7 +133,7 @@ struct userdata {
static const char* const valid_modargs[] = {
"sink_name",
"sink_properties",
- "master",
+ "sink_master",
"format",
"rate",
"channels",
@@ -1088,7 +1088,7 @@ int pa__init(pa_module*m) {
goto fail;
}
- if (!(master = pa_namereg_get(m->core, pa_modargs_get_value(ma, "master", NULL), PA_NAMEREG_SINK))) {
+ if (!(master = pa_namereg_get(m->core, pa_modargs_get_value(ma, "sink_master", NULL), PA_NAMEREG_SINK))) {
pa_log("Master sink not found");
goto fail;
}
--
1.7.4.3
_______________________________________________
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
