Issue #1603 has been updated by luke. Status changed from Needs design decision to Accepted
I'm fine with this patch, but it's not much use in the long run, because we've completely changed the internals of web serving. Normally I'd complain about the lack of tests, but I don't really care in this case because the whole subsystem is getting EOL'd relatively soon. If you look in the master branch, in network/http, there are webrick and mongrel directories. Could you add support for passenger in there? You'll need the basic wrapper class (at network/http/passenger.rb), and then the rest class that handles Puppet's abstract interface. It should be straightforward to write tests for the new code using the existing code as examples. ---------------------------------------- Feature #1603: puppetmaster inside a Rack Application (for use with Passenger) http://projects.reductivelabs.com/issues/show/1603 Author: zeha Status: Accepted Priority: Normal Assigned to: luke Category: network Target version: 0.24.6 Complexity: Unknown Affected version: 0.24.4 Keywords: puppetmaster should be able to run inside Passenger, as the Webrick server is supposed to be slow, and Mongrel doesn't fulfill my expectations of a production-usable daemon. Please find attached a patch which implements a new HTTPServer class, Puppet::Network::HTTPServer::Rack, which implements a request handler for rack applications. The patch also contains a basic Rack application (in ext/passenger/config.ru), which fires up puppet and configures Puppet::Network::HTTPServer::Rack to serve all the handlers needed for a puppetmaster. Sample config for Apache and instructions are also included. Patch should apply cleanly (only new files) and work with the 0.24.x branch of today. Certificate Revocation needs to be retested, for some reason Apache didn't like the CRL files generated by puppet, but this should be a minor issue. ---------------------------------------- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
