Issue #1460 has been updated by immerda.
jamtur01 wrote: > Are you sure this is based on 0.24.x? Looks like it's branched from master > to me. ups yeah you're right. sorry for that, I'm somehow I mess this branch stuff always a bit up, let's put 0.25 out :P. But yeah for sure this is for 0.24.x I took now the 0.24.x branch for the new commit. lutter wrote: > [...] > Looks good; two small questions/suggestions: > > (1) There's a lot of uses of the expression > [...] > it would be more readable if you set somewhere at the beginning of the file > [...] > and in the rest of the script just did tests like '[ $multiport = yes]' > > (BTW, the use of && in the test works, but it's a little ugly) ok, I addressed that in the new commit. > (2) Did you check if the stock status command does anything useful in the > multiport case ? It works for nfs - I don't have an issue with > puppetmaster_status, but less code is always better ;) hmm what exactly do you mean with stock status command? Anyway I did some tests with the status command: I killed for example one instance and the exit code of the status cmd was then != 0 and it also reported the right process as not running, so I assume it to be working as a status command should?. > > One thing that appeared on the same time on the mailing list is, that this > > feature enhancement won't work on rhel/centos versions prior to 5. I have > > addressed that in a comment where the settings are done to start > > puppetmaster as mongrel cluster. > > Yeah, that's quite a headache; but I think documenting that on RHEL < 5 > you're SOL is good enough. I don't want to get into the game of shipping > different init files and the ensuing packaging ugliness. ok then I'm happy. :) > If somebody wants this badly enough for RHEL < 5, they are more than > welcome to send a patch ;) :) > All in all, I think this is ready to be checked in, though I really would > like to > see (1) addressed. pushed "0e03ffe":http://github.com/duritong/puppet/commit/0e03ffe48a43cb6f22eb77497ae3042a4a97abdf to "tickets/0.24.x/1460":http://github.com/duritong/puppet/tree/tickets%2F0.24.x%2F1460 ---------------------------------------- Feature #1460: enhance redhat puppetmaster init.d script to easy start puppetmaster as a mongrel cluster http://projects.reductivelabs.com/issues/show/1460 Author: immerda Status: Needs design decision Priority: Normal Assigned to: lutter Category: Red Hat Target version: 0.24.6 Complexity: Unknown Patch: None Affected version: 0.24.5 Keywords: red hat init script mongrel cluster mongrel_cluster If you'd like to run puppetmaster in a mongrel cluster you have to start X instances of puppetmaster with servertype set to mongrel. With this patch you can add more than one port to the sysconfig file and puppetmaster will automatically be started with severtype set to mongrel. You can now even specify an alternate port in the sysconfig file on which puppetmaster should be run as webrick based server. See sysconfig file for more documentation. ---------------------------------------- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
