Issue #1749 has been updated by luke.

The sleeping between 0 and 1, I'm sure, is essentially a fencepost problem -- 
if splay is 300, then it doesn't matter whether the range is 0-299 or 1-300, 
but if splay is 1, then it very much matters whether the range starts at 0 or 
1, and in this case, looks like it starts at 0, so you always get the same 
value.

Looks like I should just add 1 to whatever splay time is provided.

As to the splay for 0, it looks like rand(0) returns a random float between 0 
and 1.

I think it's reasonable that Puppet's splay time just directly exposes the 
'rand' function, so I don't *really* consider either of these bugs.
----------------------------------------
Bug #1749: splaylimit parameter behaves oddly for low values
http://projects.reductivelabs.com/issues/show/1749

Author: ohookins
Status: Needs more information
Priority: Low
Assigned to: luke
Category: executables
Target version: 
Complexity: Unknown
Affected version: 0.24.6
Keywords: 


<pre>
puppetd --onetime --no-daemonize --ignorecache -v --splaylimit=1
info: Loading fact trogdorbuild
info: Sleeping for 0 seconds (splay is enabled)
</pre>

In about 50 invocations of puppetd with splaylimit set to 1 second I couldn't 
get it to splay for 1 second once. Perhaps this is just due to the 
randomization function used. But this is not the strangest behaviour I've seen 
anyway.

<pre>
[EMAIL PROTECTED]:~# puppetd --onetime --no-daemonize --ignorecache -v 
--splaylimit=0
info: Loading fact trogdorbuild
info: Sleeping for 0.658507330660304 seconds (splay is enabled)
</pre>
With splaylimit set to 0 it now sleeps for a floating point number between 0 
and 1. Not at all expected behaviour (even though the impact of such a bug is 
very low).



----------------------------------------
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://reductivelabs.com/redmine/my/account

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to