Issue #1903 has been updated by luke.
Heh, just to be clear -- it's a ton of work, because both noop and schedule are recursive in the graph (that is, when attached to a class or definition they should affect the contained resources), but the recursion is handled via metaparam inheritance. Thus, we have to find a way to make them recursive. The best way I can find is to have the transaction track them when sorting the resources, since any other recursion would be really expensive (i.e., asking every resource whether its parent is noop, or its parent's parent, or...), but that tracking is beyond our graph library's meagre skills right now. Fortunately, the relationship metaparams just modify the graph directly, so it's not a problem. Really, it'd be best if we just got rid of the topsort, and switched to a system that just recursively walked the graph but knew how to color certain parts of the graph as noop and/or scheduled. I just don't think I'm quite up to that. ---------------------------------------- Feature #1903: Metaparams should no longer inherit to contained resources http://projects.reductivelabs.com/issues/1903 Author: luke Status: Accepted Priority: Normal Assigned to: luke Category: language Target version: 0.25.0 Complexity: Unknown Affected version: 0.24.7 Keywords: This feature was present because we weren't actually passing a real catalog to the client, only weird recursive structures. Now that, in 0.25, we'll be passing a real catalog, we can get rid of this. If someone specifies a relationship to or on a container object (class, definition, or node), that relationship is handled comfortably in the graph, so we don't need to worry about passing them on explicitly in the language. This should significantly clean up some currently messy code, but it will require a bit of diligence to make sure it all works correctly. I'm marking this for 0.25, but eh, it might get bumped. It's not *too* much work, since it's mostly about removing code and testing, but who knows. ---------------------------------------- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
