Issue #2184 has been updated by masterzen.

Do you have evidence of this?

I don't really see how it is possible, because anyway the OS will perform read 
ahead, so you'll finally end-up reading 4096 bytes or more, but you'll checksum 
4096 bytes instead of 512 (not that might change anything on a performance 
point of view).
----------------------------------------
Bug #2184: Checksums should use a larger buffer size
http://projects.reductivelabs.com/issues/2184

Author: luke
Status: Accepted
Priority: Normal
Assigned to: luke
Category: file
Target version: 0.25.0
Complexity: Unknown
Affected version: 0.24.7
Keywords: 


Apparently 512 bytes is below the block size of many filesystems, so our use of 
that size buffer for checksums causes some inefficiency.  The buffer size 
should be increased to 4096 or so.

This should be an essentially trivial fix.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://reductivelabs.com/redmine/my/account

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to