Issue #2444 has been updated by Markus Roberts.
There are actually two issues here:
# The tests were depending on the serialization order of hashes, and thus would
fail whenever they were serialized in an unexpected order
# This was masking what appears to be an actual failure in the second test:
<pre>
ActiveSupport::JSON::Encoding::CircularReferenceError in
'Puppet::Network::Format[json] when json is available should be able to render
multiple instances to json'
object references itself
./spec/integration/network/formats.rb:25:in `to_json'
./lib/puppet/network/format.rb:68:in `send'
./lib/puppet/network/format.rb:68:in `render'
./spec/integration/network/formats.rb:81:
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
</pre>
I've sent a patch for the first to the list, will start on the second shortly.
----------------------------------------
Bug #2444: json test failures
http://projects.reductivelabs.com/issues/2444
Author: Markus Roberts
Status: Needs more information
Priority: Normal
Assigned to: Markus Roberts
Category: testing
Target version: 0.25.0
Complexity: Unknown
Affected version: 0.25.0beta2
Keywords:
Two of the json tests are failing in the 0.25.0beta2 and in master as of 24
July 2009. I have not analyzed this further and am simply noting the failures
here for the record.
<pre>
'Puppet::Network::Format[json] when json is available should be able to render
an instance to json' FAILED
expected: "{\"json_class\":\"JsonIntTest\",\"data\":[\"foo\"]}",
got: "{\"data\":[\"foo\"],\"json_class\":\"JsonIntTest\"}" (using ==)
./spec/integration/network/formats.rb:62:
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
</pre>
<pre>
@NoMethodError in 'Puppet::Network::Format[json] when json is available should
be able to render multiple instances to json'
undefined method `string' for ["one"]:Array
./spec/integration/network/formats.rb:10:in `=='
./spec/integration/network/formats.rb:25:in `to_json'
/home/markus/projects/puppet/puppet/lib/puppet/network/format.rb:68:in `send'
/home/markus/projects/puppet/puppet/lib/puppet/network/format.rb:68:in `render'
./spec/integration/network/formats.rb:69:
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
</pre>
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://reductivelabs.com/redmine/my/account
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---
