Issue #2405 has been updated by Luke Kanies. Category set to FreeBSD Status changed from Unreviewed to Ready for Checkin Assigned to set to James Turnbull Target version set to 0.25.0
This is a very small change, and we don't currently have tests for the valid values in this parameter, so this code is fine. ---------------------------------------- Bug #2405: Mount parameter "dump" doesn't accept all valid values on FreeBSD http://projects.reductivelabs.com/issues/2405 Author: Ryan Langseth Status: Ready for Checkin Priority: Normal Assigned to: James Turnbull Category: FreeBSD Target version: 0.25.0 Complexity: Trivial Affected version: 0.24.8 Keywords: On FreeBSD system the default value for "dump" within fstab is 2 Puppet complains this is invalid when managing "dump" I did not change anything within the defaultto, for FreeBSD systems this is 2 for everything except / which is 1 <pre> --- mount.rb 2009-07-09 20:08:18.000000000 -0500 +++ mount.rb.new 2009-07-09 20:07:47.000000000 -0500 @@ -141,7 +141,12 @@ newproperty(:dump) do desc "Whether to dump the mount. Not all platforms - support this. Valid values are ``1`` or ``0``. Default is ``0``." + support this. Valid values are ``1`` or ``0``. or ``2`` on FreeBSD, Default is ``0``." + if Facter["operatingsystem"].value == "FreeBSD" + newvalue(%r{(0|1|2)}) + else + newvalue(%r{(0|1)}) + end defaultto { if @resource.managed? </pre> -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
