Issue #2469 has been updated by Luke Kanies. Status changed from Code Insufficient to Tests Insufficient
I like this much better; having a nil path makes sense. Are there existing tests for the filebucket type? My assumption is no. Could you add a couple of simple tests just to verify the settings propagate correctly? ---------------------------------------- Feature #2469: support filebucket to use the puppetmaster as default remote server http://projects.reductivelabs.com/issues/2469 Author: Till Maas Status: Tests Insufficient Priority: Normal Assigned to: Category: file Target version: Complexity: Unknown Affected version: 0.24.8 Keywords: The patch I attach adds the parameter "remote" to the filebucket type, which makes it possible to use the puppetmaster that is specified in the config as the default puppetmaster. It should not disrupt existing configurations, but allows to use the filebucket from the remote puppetmaster server by default with this manifest: filebucket { main: remote => true } A more elegant solution would probably be to make the values of Puppet[:server] available as a fact/pre defined variable for the client, but I do not now how to do this and the only hints for predefined variables (servername, serverip) seem to be generated at the host. So if it is easily possible to create such a variable, e.g. $puppter_config_server that has the value of Puppet[:server] for puppetd. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
